search

Nonprofit-Exchange-Hub / web-app

Nonprofit Circle (formerly Nonprofit Exchange Hub) A hub for the exchange of goods, information and connections for nonprofits of all sizes.
MIT License
29 stars 19 forks source link

updated the footer with the mockup provided #362

Closed EtoKruto closed 1 year ago

EtoKruto commented 1 year ago

still need confirmation on correct navlinks

EtoKruto commented 1 year ago

@marvinsjsu, can you confirm if the links used are correct or if we should link to the 'Our Mission" page, which hasn't been created yet? I could not find it in the mockups, so I want to confirm.

marvinsjsu commented 1 year ago

@EtoKruto, this all looks great. I think the links are going to the right pages, if not, we'll create a new ticket for any needed update. I'm not sure if you were able to get the padding/margin to help determine spacing of the elements in Figma (I wasn't able to), so I've asked UI/UX if they can help with this. The only visual comment I have is with regards to the elevation (the box-shadowing) of the footer itself - it can be adjusted to match closer to what we have on the mocks. Other than that, I'll go over the code sometime this evening, but functionally it looks great!

Currently:

Screenshot 2023-07-27 at 12 50 14 PM

Figma mockup:

Screenshot 2023-07-27 at 12 51 18 PM
EtoKruto commented 1 year ago

@marvinsjsu should be good to go for the review. Thanks!