other ignored number characters in name generation

Nonprofit-Open-Data-Collective / irs-efile-master-concordance-file

The Master Concordance File defines standards and provides documentation necessary to build structured databases from the IRS E-File XML files posted on AWS.

https://nonprofit-open-data-collective.github.io/irs-efile-master-concordance-file/

40 stars 6 forks source link

other ignored number characters in name generation #12

Closed jsfenfen closed 6 years ago

jsfenfen commented 6 years ago

name generation bug also seems to have created similar var names for sked a 509 / 170 stuff, i.e. SA_02_PZ_TRLOBCTYMYEA3 is both:

/Return/ReturnData/IRS990ScheduleA/TaxRevLeviedOrgnztnlBnft509Grp/CurrentTaxYearMinus3YearsAmt

Note that even though the 'minus' year thing was fixed there's still a problem between TaxRevLeviedOrgnztnlBnft170Grp and TaxRevLeviedOrgnztnlBnft509Grp.

jsfenfen commented 6 years ago

It seems like 170/509 has a pretty substantial overlap with minus year stuff, but it's mostly resolved here: https://github.com/Nonprofit-Open-Data-Collective/irs-efile-master-concordance-file/pull/13/commits/1f9267393311029e0b73feb7579ebb4be6aaadef