hand fix eleven variables

Nonprofit-Open-Data-Collective / irs-efile-master-concordance-file

The Master Concordance File defines standards and provides documentation necessary to build structured databases from the IRS E-File XML files posted on AWS.

https://nonprofit-open-data-collective.github.io/irs-efile-master-concordance-file/

40 stars 6 forks source link

hand fix eleven variables #18

Closed jsfenfen closed 6 years ago

jsfenfen commented 6 years ago

hey @lecy, @borenstein I wanted to see how it would work if I just started fixing stuff by hand--here's the eleven I got through. Some of this required a bit of research as well. Do we have a 'process' for this? I tried to break each variable into a commit (and you can see occasionally didn't get it quite right). But the diffs are fairly 'visually' useful, that's been my goal, anyways.

lecy commented 6 years ago

This seems like a reasonable approach to me. It makes it easy to search for a change made to a specific variable.

If we updated the concordance by parts, that would also make it possible to search for changes.

jsfenfen commented 6 years ago

Ok @lecy I'm gonna merge this