search

Nonprofit-Open-Data-Collective / irs-efile-master-concordance-file

The Master Concordance File defines standards and provides documentation necessary to build structured databases from the IRS E-File XML files posted on AWS.
https://nonprofit-open-data-collective.github.io/irs-efile-master-concordance-file/
40 stars 6 forks source link

F9_08_PF_SIGOCAFFRFAC contain mixed references to city and country #25

Open nsudarsanam opened 6 years ago

nsudarsanam commented 6 years ago

Firstly, thank you for doing this! I was manually extracting variables I was interested in from various schema files and the concordance csv has definitely made my life easier!

I found that various instances of F9_08_PF_SIGOCAFFRFAC refer to both foreign recipients city and country. Would these need to be split up into separate CO/CI variables? That sort of split have been done in other places.

jsfenfen commented 6 years ago

Hi @nsudarsanam and thanks so much for reporting this! I think the CO/CI split makes sense, assuming there aren't any variables that already have those names by happenstance (there probably aren't, I just haven't checked). Can you suggest, precisely, the changes that should take place to resolve this? What I mean is, can you come up with a precise list of xpaths that require variable name alteration and what the new variable name for these should be?

There's a number of lists of 'problem' variables we've generated that need fixes: this appears in https://github.com/jsfenfen/irs-efile-master-concordance-file/blob/master/qa/prob_vars.csv for instance. The hard part is coming up with the fix!