Admin page tabs aren't exposed as tabs to screen readers

NoobishSVK / fm-dx-webserver

FM-DX Webserver is a cross-platform web server designed for FM DXers who want to control their radio receivers through a web interface.

https://fmdx.org/projects/webserver.php

GNU General Public License v3.0

29 stars 21 forks source link

Admin page tabs aren't exposed as tabs to screen readers #55

Closed marvellousmachine closed 1 month ago

marvellousmachine commented 3 months ago

In the Admin page, there are tabs such as Dashboard, Tuner, Connection etc. Please, consider making these tabs exposed to screen readers via ARIA: tab role. https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Tab_Role

NoobishSVK commented 3 months ago

Added multiple roles including tablists, presentation and tabpanel roles, I hope this will help.

marvellousmachine commented 3 months ago

Yes, currently the tabs are properly indicated. The minor problem remains proper keyboard navigation.

Current situation:

When tabbing / Shift+tabbing, every tab receives focus.
I can activate it by pressing Enter.

Ideal situation:

When tabbing / Shift+tabbing, only the currently selected tab receives focus.
I can move through all the tabs using left / right arrows
I can activate the focused tab selected in the previous step by pressing Enter.

Thanks.

marvellousmachine commented 2 months ago

I've checked the behavior in multiple web apps that use tabs (Azuracast, Messenger, Alza) and nobody does it right. If it's too much tinkering, feel free to leave it at its current state, it's certainly usable the way it is now.

NoobishSVK commented 1 month ago

I have changed a few things related to this, can you try, please?

marvellousmachine commented 1 month ago

Works great now. Thank you.