Accessibility: Not possible to close the Settings panel using keyboard

NoobishSVK / fm-dx-webserver

FM-DX Webserver is a cross-platform web server designed for FM DXers who want to control their radio receivers through a web interface.

https://fmdx.org/projects/webserver.php

GNU General Public License v3.0

29 stars 21 forks source link

Accessibility: Not possible to close the Settings panel using keyboard #56

Closed marvellousmachine closed 1 month ago

marvellousmachine commented 3 months ago

Similarly to #51, it is not possible to close the Settings panel using the keyboard. Please add the button role with the appropriate label here as well and make sure for it to receive focus when tabbing / Shift+tabbing.

NoobishSVK commented 1 month ago

I have added roles and aria labels for this, would it be possible for you to check? Thanks!

marvellousmachine commented 1 month ago

Works great. Would it be possible to make it focusable when tabbing as well?

NoobishSVK commented 1 month ago

I have added the tabindex option, would you mind trying it out? Thank you!

marvellousmachine commented 1 month ago

Fixed. Thanks.