Properly handle someone sending in both excludedetails and thumbsize

Nookipedia / nookipedia-api

Nookipedia's custom API for querying data from the Animal Crossing video game series.

https://api.nookipedia.com/

MIT License

42 stars 12 forks source link

Properly handle someone sending in both excludedetails and thumbsize #23

Closed KevinPayravi closed 3 years ago

KevinPayravi commented 4 years ago

Currently, if someone sends in both excludedetails=true and thumbsize=##, the server responds with a 500 error as it will try to generate thumbnails based on non-existence image fields (since excludedetails results in only the required fields being queried).

API should be updated to properly account for this case by returning a 400 error indicating that one or the other should be provided, not both.

KevinPayravi commented 3 years ago

Resolved via https://github.com/Nookipedia/nookipedia-api/pull/25