search

Noovolari / leapp

Leapp is the DevTool to access your cloud
https://www.leapp.cloud/
Mozilla Public License 2.0
1.62k stars 146 forks source link

Enable Brew Cask autoupdate #192

Open andreacavagna01 opened 3 years ago

andreacavagna01 commented 3 years ago

Is your feature request related to a problem? Please describe. Autoupdate brew cask formula by following this documentation: https://docs.brew.sh/Cask-Cookbook

This in order to modify this formula

https://github.com/Homebrew/homebrew-cask/edit/master/Casks/leapp.rb

making the formula version agnostic and enabling Autoupdate checks and download via Brew

nitrocode commented 3 years ago

Doesn't the liveupdate only allowing running brew bump-cask-pr leapp --version=xyz ?

formula link https://github.com/Homebrew/homebrew-cask/blob/master/Casks/leapp.rb

I think it would be better to setup a github action to bump it up

Maybe something like this would work ?

on:
  push:
    tags: 'v*'

jobs:
  homebrew:
    name: Bump Homebrew formula
    runs-on: ubuntu-latest
    steps:
      - uses: mislav/bump-homebrew-formula-action@v1
        with:
          # A PR will be sent to github.com/Homebrew/homebrew-cask to update this formula:
          formula-name: leapp
          formula-path: Casks/leapp.rb
          homebrew-tap: Homebrew/homebrew-cask
        env:
          COMMITTER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
andreacavagna01 commented 2 years ago

Need to check it out, can you test it?

andreacavagna01 commented 2 years ago

Basically, Leapp provide an asset link with:

nitrocode commented 2 years ago

Hmmm... I thought this was already added it ?

https://github.com/Noovolari/leapp/pull/213#issuecomment-1021442430

But now I don't see this in the default branch of this repo.

Bumped the formula again to 0.9.0 https://github.com/Homebrew/homebrew-cask/pull/119637

davidlj95 commented 5 months ago

I think we can close this as the package will be autobumped by brew's GitHub Actions autobump workflow