search

Noovolari / leapp

Leapp is the DevTool to access your cloud
https://www.leapp.cloud/
Mozilla Public License 2.0
1.59k stars 146 forks source link

Handling custom AWS SAML endpoint uri #465

Open amnacog opened 11 months ago

amnacog commented 11 months ago

Describe the bug I have this endpoint to initiate the AWS authentication: https://xx/openam/idpssoinit?realm=/IDP&metaAlias=/IDP/DEFAUT&spEntityID=urn:amazon:webservices

but from aws-saml-assertion-extraction-service.ts:8 const authenticationUrlRegexes = the regex will not work and the authentication will fail.

I already fixed it in a local build by adding this line: /^https:\/\/.*urn:amazon:webservices.*/,

Could it be possible to add this regex (or another more enforced regex) to handle openam (or any custom endpoint) that use arn:amazon:webservices ?

Leapp Version v0.18.5

To Reproduce Not applicable.

Expected behavior Authentication passthrough

andreacavagna01 commented 9 months ago

Hi @amnacog, good point. It could be a good point to add a custom filter for specific regex to make the App more flexible. is it that what you need?

amnacog commented 9 months ago

@andreacavagna01 Adding the proposed regex in my initial message would resolve my needs, but yes maybe it would be great to add authentication regex url on the go in experts param (or else)