AWS SSO asks to confirm device code but Leapp doesn't give one

[imaginaryCorn]

Describe the bug A code confirmation comes up in the AWS SSO devices auth where one didn't exist before. The code to confirm doesn't appear in the Leapp UI.

Leapp Version 0.20.0

To Reproduce Steps to reproduce the behavior:

1. Login to AWS Single Sign-on through Leapp
2. The browser or in-app page opens to https://device.sso.*.amazonaws.com/?user_code=xxx and asks to confirm user code given to you.
3. Leapp gives the user no code to check against.

Expected behavior Leapp should show the code in its UI that comes from the call to the AWS SSO API, so users can visually confirm which device is requesting SSO access.

Screenshots (code whited out)

Desktop (please complete the following information):

• OS: MacOS
• OS Version Ventura 13.5.2
• Leapp Version 0.20.0

[nilsdebruin]

I can confirm that this is also the case in version 0.19.0 (same confirmation code pop-up)

Desktop (please complete the following information):

• OS: MacOS
• OS Version Ventura 13.5.2
• Leapp Version 0.19.0

[pethron]

Thank you guys for reporting. We'll look into this.

[pethron]

AWS changed the flow these days. Are you guys still able to use SSO even without seeing the code? It should be a quick fix to display the code in case it's sent in the request, but I wanted to confirm first if this is breaking Leapp functionalities.

[siipimutteri]

It's still usable. Just need to press "Confirm and continue" without ability to check the code and then more familiar "Authorize request" with just Accept and Cancel is shown.

[pethron]

Hi guys, I couldn't reproduce this issue on 0.20.0 in-app and in-browser. It's strange it's happening to you because we don't manipulate the pages sent by AWS or other providers. Can you confirm you're still experiencing the issue?

[nilsdebruin]

@pethron Yes, I am still experiencing this (also our team members, versions 0.19.0 and 0.20.0 Mac)!

[pethron]

I'm confused about the issue, so I'll rephrase it so we can proceed.

Can you confirm that when you do the authentication flow, you see the code in leapp? Be it in-browser or in-app (like the screenshot below), and does it change with each new request?

The main point of the issue is that you don't find the code displayed outside of Leapp to compare with the one shown. Is that correct?

I expected AWS to send an email, an SMS, or something similar, but this code appears nowhere. I'm investigating this feature since I need to understand if AWS devised this to let the client send an email, SMS, or any other channel to transmit the code or if there's an API to call to send this code somehow.

This could be a problem for Leapp since to send the code, it would need an email, SMS, or, in general, an external service to send the code. Alternatively, we could display the code inside Leapp without sending it.

[mattzcarey]

I'm confused about the issue, so I'll rephrase it so we can proceed.

Can you confirm that when you do the authentication flow, you see the code in leapp? Be it in-browser or in-app (like the screenshot below), and does it change with each new request?

The main point of the issue is that you don't find the code displayed outside of Leapp to compare with the one shown. Is that correct?

I expected AWS to send an email, an SMS, or something similar, but this code appears nowhere. I'm investigating this feature since I need to understand if AWS devised this to let the client send an email, SMS, or any other channel to transmit the code or if there's an API to call to send this code somehow.

This could be a problem for Leapp since to send the code, it would need an email, SMS, or, in general, an external service to send the code. Alternatively, we could display the code inside Leapp without sending it.

We are getting this also. I would suggest displaying the code inside Leapp would be best. :)

Also @pethron can you settle a debate for us?

Is Leapp pronounced le-app or lee-ap?

Best, Matt

[pethron]

Thanks everyone for the clarification. We're trying to find a way to display the code before redirecting to the portal. It's unclear if we can display that starting from the portal URL.

Quoting the docs :)

The name Leapp is based on the word leap and is pronounced /l:ip/. We chose this name because the project enables you to be one step away from your cloud environments.

[pethron]

We found a way to show the code inside Leapp before sending the request. It will be available in the next release.

[andreacavagna01]

Since no action is required, I think the message displaying is meaningless.

Should we think to change the wording?

Also a double modal is clearly an UI antipattern, there is an alternative method for it?

[pethron]

Closing issue as fixed with version 0.20.1. Feel free to reopen if you experience problems.