search

Noovolari / leapp

Leapp is the DevTool to access your cloud
https://www.leapp.cloud/
Mozilla Public License 2.0
1.62k stars 147 forks source link

fix: change the authentication URL regexp for Auth0 provider #475

Closed maintux closed 1 year ago

maintux commented 1 year ago

Changelog

Bugfixes

At the moment, the regexp used to check if the URL is an authentication URL for Auth0 checks if /samlp is in the URL. The correct one instead checks if /u/login is present. This misconfiguration causes the opening of the login modal window for every credential refresh process because the needAuthentication method always resolves with true.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Giaco9 commented 1 year ago

Hi everyone, do you have any timeline for releasing this? I'm currently using Auth0 as an identity provider, and the bug this PR would solve is really annoying. I checked the pull-request #321, and it has the same failed check about "Incomplete regular expression for hostnames", but has been merged without a fix. Maybe @rick-rtt could help also this time? If needed I can help in testing this :)

Thank you again @maintux and the Leapp team, as #321 this pull-request would really helpful for me :)

andreacavagna01 commented 1 year ago

We are going to release this feature this week! thanks for the support guys!