search

Noovolari / leapp

Leapp is the DevTool to access your cloud
https://www.leapp.cloud/
Mozilla Public License 2.0
1.62k stars 147 forks source link

feat: make Web Console URL log out from current browser session #520

Closed adamantike closed 9 months ago

adamantike commented 10 months ago

Changelog

Enhancements

This change to the Web Console URL makes AWS log out from any existing browser session, which avoids requiring a manual logout.

The implemented approach is based on [1] and its replies. It was found during testing that the sign-in links require the us-east-1 domain prefix. Otherwise, the URL either redirects to the AWS Console landing page, or returns a 400 error.

Closes #309.

Notes

I tested this change with AWS SSO and many AWS accounts, in multiple regions for US and EU. I don't have access to any AWS GovCloud account, so it would be interesting if anyone can test this change and validate whether it works for GovCloud.

[1] https://serverfault.com/a/1097528

sonarcloud[bot] commented 10 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ericvilla commented 9 months ago

Hi @adamantike, thanks for the PR! We've just merged it into master. We're going to test it; in addition, we're going to update the token expiration, from 1h to 12h. It is possible, as described in the documentation.

adamantike commented 9 months ago

Thanks Eric! Glad to see this merged.