Noovolari / leapp

Leapp is the DevTool to access your cloud
https://www.leapp.cloud/
Mozilla Public License 2.0
1.6k stars 146 forks source link

Session is not started after MFA is entered #540

Closed AlessandroVol23 closed 6 months ago

AlessandroVol23 commented 6 months ago

Describe the bug I use Leapp with AWS SSO and multiple accounts. After I enter MFA I get an approved cookie request two times which I normally don't get.

And then I get this screen: image

It doesn't close automatically. Once I close it manually no session has started.

Leapp Version 0.24.6

To Reproduce Steps to reproduce the behavior:

  1. Try to start the session
  2. Enter username
  3. Enter password
  4. Enter MFA
  5. Error

Expected behavior Session should start. It works with other AWS Accounts. It works for other people in the same AWS Account

Screenshots image

Desktop (please complete the following information):

remixtj commented 6 months ago

Hello @AlessandroVol23 we have the same issue and switched auth method from in-app to in-browser

image

ericvilla commented 6 months ago

Thanks for reporting. I've just tried using the in-browser login and it works. Let me check the in-app one

AlessandroVol23 commented 6 months ago

Hello @AlessandroVol23 we have the same issue and switched auth method from in-app to in-browser

image

Thanks! That fixes it for me as well 😊

Anthonycyr commented 6 months ago

Same problem here this morning, the in-browser fixed it :)

remixtj commented 6 months ago

Can you please tell in which region is your IAM Identity Center configured? We're using eu-central-1

Anthonycyr commented 6 months ago

of course ! Us-east-1 and ca-central-1

Le lun. 18 mars 2024, à 12 h 24, Luca Lorenzetto @.***> a écrit :

Can you please tell in which region is your IAM Identity Center configured? We're using eu-central-1

— Reply to this email directly, view it on GitHub https://github.com/Noovolari/leapp/issues/540#issuecomment-2004374191, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKHW5XA5SQ7NMIHC4BFTRKLYY4IKPAVCNFSM6AAAAABEXNLSH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGM3TIMJZGE . You are receiving this because you commented.Message ID: @.***>

iflare3g commented 6 months ago

Yeah it seems the new change introduced by AWS broke the in-app login I'm experiencing the same since yesterday

sethwrowan commented 6 months ago

This appears to be related to a new UI AWS introduced for its Access Portal, which I'm guessing Leapp uses for its in-app authentication method.

Anthonycyr commented 6 months ago

Yess, it's related for sure !

On Thu, Mar 21, 2024, 2:23 p.m. Seth Rowan @.***> wrote:

This appears to be related to a new UI AWS introduced for its Access Portal, which I'm guessing Leapp uses for its in-app authentication method.

— Reply to this email directly, view it on GitHub https://github.com/Noovolari/leapp/issues/540#issuecomment-2013231270, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKHW5XB7K2EP6JPZQG2HLDLYZMQS5AVCNFSM6AAAAABEXNLSH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJTGIZTCMRXGA . You are receiving this because you commented.Message ID: @.***>

ericvilla commented 6 months ago

We’ve just released a test build that should solve the AWS SSO in-app authentication flow. We want to thank you for your patience and ask you to download and test the build available here. Let us know if you have problems downloading and testing it. Your feedback is crucial!

remixtj commented 6 months ago

Hello,

i just tested and i keep getting cookies request and workflow doesn't continue.

Luca

ericvilla commented 6 months ago

Yeah, I just noticed I've added support to eu-west-1 only. I'm going to release a build with support to other regions

iflare3g commented 6 months ago

We’ve just released a test build that should solve the AWS SSO in-app authentication flow. We want to thank you for your patience and ask you to download and test the build available here. Let us know if you have problems downloading and testing it. Your feedback is crucial!

Hello @ericvilla , I can confirm the build works properly by using eu-west-1! thanks a lot!!

ericvilla commented 6 months ago

New build available: https://github.com/Noovolari/leapp/actions/runs/8449474949

mary2501 commented 6 months ago

That build doesn't work image

ericvilla commented 6 months ago

There was a problem during the v0.25.3 release process. We're going to release a fix right now

ericvilla commented 6 months ago

Just released v0.25.3. It should fix this issue. We're going to close it. Feel free to re-open it if something goes wrong during AWS SSO in-app login