search

Noovolari / leapp

Leapp is the DevTool to access your cloud
https://www.leapp.cloud/
Mozilla Public License 2.0
1.56k stars 143 forks source link

fix(core): remove typo on generating web session signin token #559

Closed petrusdemelo closed 1 month ago

petrusdemelo commented 2 months ago

Changelog

Corrected case sensitivity issue in query parameters for session duration in sign-in token generation.

Bugfixes

Fixed a bug where the session duration parameter was ignored due to a case sensitivity error in the query string. This issue caused Amazon's default session duration of 1 hour to be used regardless of the intended duration.

Enhancements

Enhanced the reliability of session duration handling by fixing the typo in the parameter name from sessionDuration to SessionDuration.

Notes

This fix aligns the parameter casing with Amazon's API requirements, ensuring that session duration settings are correctly applied. This change is crucial for systems that depend on longer session durations for extended operations.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

petrusdemelo commented 1 month ago

Hey @ericvilla

Don't want to bug you, just would like to do quick poke :)