NoppesTheFolf
commented
3 months ago Hey! Instead of adding e6AI to that existing enum, perhaps it would be nice to make the base URL configurable instead, like you already sort of suggested. The reason I don't really like adding e6AI to that existing enum is because it can give the impression E621Client "officially" supports that site. If they ever lack behind e621 on what their API is capable of, I don't intend (new versions of) this library to be backwards compatible.
My concrete suggestion would be to:
- Mark the Imageboard enum (and all things that use it) as deprecated
- Add the base URLs of e621 and e926 to the E621Constants class
- Add a method to the builder to configure a base URL
I'm also willing to approve the PR you made and update the NuGet package. I'll probably do the above refactoring myself some time in that case. Let me know!
GizmoCaritate
I noticed this client only supports E621 and E926. Recently a new imageboard called E6AI has been added that is running the E621 framework on the site, using the same API.
I would like to implement this imageboard to use it in my bot, since the client only allows you to select an imageboard using an Enum and not passing in the base URL yourself.
I will try to make a PR for this as soon as i can. Hopefully you will allow it to be part of the main project so i can use it in my bot.