search

NorESMhub / BLOM

Bergen Layered Ocean Model
GNU Lesser General Public License v3.0
16 stars 25 forks source link

Minor fixes for configuration and namelist creation #303

Closed JorgSchwinger closed 7 months ago

jmaerz commented 7 months ago

Hi @JorgSchwinger , it shouldn't conflict with #305, but maybe it would be good to merge it nevertheless (I took myself out as a reviewer).

JorgSchwinger commented 7 months ago

I have put this on hold since it will interfere with the regression testing. There will be a fix needed since the C-isotope code cannot be switched on via user-namelist, but needs to go via env_run.xml.

@mvertens if you can tell me how to fix this, I could include it into this PR. Unless you think it is easier if you fix this after merging this PR?

mvertens commented 7 months ago

@JorgSchwinger -

in blom/cime_config/testdefs/testmods_dirs/blom/hamocc1/ add a file shell_commands and in that file add the line ./xmlchange HAMOCC_CISO=TRUE and in user_nl_blom remove the line use_cisonew = .true.

You need to do this for every new xml variable that was introduced for the user_nl_blom variables that are in the user_nl_blom file

You should also do this for in blom/cime_config/testdefs/testmods_dirs/blom/hamocc2/

That should be it. Does that make sense?

JorgSchwinger commented 7 months ago

Ok thank you for the instructions @mvertens, done.

I guess then this PR can be merged?

mvertens commented 7 months ago

That would be fine with me.