search

NorESMhub / BLOM

Bergen Layered Ocean Model
GNU Lesser General Public License v3.0
16 stars 25 forks source link

add missing configurations for the ATRC option #341

Closed YanchunHe closed 4 months ago

YanchunHe commented 4 months ago

add missing configurations for the ATRC option

ATRC is used as compiler option in BLOM, but it is not defined.

add ATRC option in the namelist building script and in the XML files.

TomasTorsvik commented 4 months ago

@YanchunHe Hi, I see you start from the v1.1.0 tag when you add your changes, and want to push to master. However, there are some conflicts due to the source code having evolved. The current master should contribute to NorESM2.3. If you want these changes to be available for CMIP6-version of NorESM2 (currently NorESM2.0.7 is the latest), changes should be added on top of v1.4.0, and for NorESM2.1 the relevant tag is v1.5.1.1. Do you want to include the ATRC option for all these NorESM versions, or only the upcoming NorESM2.3? In any case, I think it would make the process easier if you start from a more up to date source code.

TomasTorsvik commented 4 months ago

@YanchunHe - I have created a new PR #346 that adds this functionality on top of the current master branch. If you need this for CMIP6-type simulations, I suggest to start with the v1.4.0 tag. In either case, I suggest that this should not be merged to master as it will create conflicts. I therefore label it "invalid" for now.

YanchunHe commented 4 months ago

This has been merged in #346

I close here.