gold2718
commented
2 months ago One question: The purely cosmetic changes in some of the files, typically removal of empty characters at the end of the line. Is that on purpose or is it caused by using different editing tools?
I have all my editors set to automatically remove spaces at the end of each line when saving a file. This is the practice we adopted at NCAR to (eventually) lower the number of spurious changes presented in a PR. Note that when reviewing a PR, you can always hide these whitespace changes. Just below the "Files changed" tab is a gear icon. Clicking on that reveals a "Hide whitespace" checkbox which will hide those changes for easier reviewing. I plan to continue this practice as I edit files since many have accumulated a lot of these extra spaces over the years. Let me know if that is a problem or if you would like to also adopt the practice.
oyvindseland
Summary: Make KeyClim Cloud2 tunings the default for NFHIST and HF1850
Contributors: gold2718, oyvindseland
Reviewers: DirkOlivie, oyvindseland
Purpose of changes: Prepare compsets to use KeyClim Cloud2 tunings as the default
Github PR URL: https://github.com/NorESMhub/CAM/pull/142
Changes made to build system: None
Changes made to the namelist: Added new namelist items to allow for new tuning parameters
Changes to the defaults for the boundary datasets: None
Substantial timing or memory changes: None
Test suite aux_cam_noresm runs with the expected namelist and baseline changes
Issues addressed by this PR: Create new compsets for NorESM2.3, NorESMhub/NorESM#465