Need review pull request to fix branch run.

NorESMhub / CTSM

Community Terrestrial Systems Model (includes the Community Land Model of CESM)

http://www.cesm.ucar.edu/models/cesm2.0/land/

Other

2 stars 9 forks source link

Need review pull request to fix branch run. #10

Closed blcc closed 3 years ago

blcc commented 3 years ago

Hi, I am preparing the release of NorCPM, which is a set of scripts to do data assimilation with NorESM. NorCPM use branch as RUN_TYPE to do simulation. In CTSM, branch is not allowed but it should be. The bug was submitted at CLM at ESCOMP and fixed with tiny modification. Please see following issue: https://github.com/ESCOMP/ctsm/issues/786 The pull request of this fix is submitted. Please review and merge it to master branch.

huitang-earth commented 3 years ago

@blcc The changes are not supposed to go to the master branch in CTSM repo. Please find the appropriate branch for your changes.

MichaelSchulzMETNO commented 3 years ago

The master is not yet uptodate with ESCOMP. The branch for NorESM2 is this one: release-clm5.0.14-Nor. Would this be the one to merge you change into?

blcc commented 3 years ago

@huitang-earth @MichaelSchulzMETNO Thanks you very much. My PR is wrong at branch. I'll create another one to release-clm5.0.14-Nor.