search

NorESMhub / CTSM

Community Terrestrial Systems Model (includes the Community Land Model of CESM)
http://www.cesm.ucar.edu/models/cesm2.0/land/
Other
2 stars 9 forks source link

put in changes needed for addition of new dglc component #72

Closed mvertens closed 3 months ago

mvertens commented 3 months ago

Description of changes

change needed for the addition of a dglc component in cdeps

Specific notes

This minor change to buildnml is needed in order to support the addition of dglc which will replace CISM running in noevolve mode. This will enable having many of the current CTSM tests that use SGLC move to using DGLC%NOEVOLVE.

Contributors other than yourself, if any: None

CTSM Issues Fixed: None

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any: Ran a test case with compset 1850_DATM%GSWP3v1_CLM50%SP_SICE_SOCN_SROF_DGLC%NOEVOLVE_SWAV and resolution f10_f10_ais8gris4_mg37 and compared to compset 1850_DATM%GSWP3v1_CLM50%SP_SICE_SOCN_SROF_CISM%NOEVOLVE_SWAV and resolution f10_f10_ais8gris4_mg37

mvertens commented 3 months ago

@mvdebolskiy - if you okay with this PR can you please accept the review and merge it (or I'm happy to merge it).

mvertens commented 3 months ago

Also - I don't understand why black is failing. With the changes I've put in - it passes for ESCOMP and there is no statement as to what the failure is.

mvdebolskiy commented 3 months ago

Also - I don't understand why black is failing. With the changes I've put in - it passes for ESCOMP and there is no statement as to what the failure is.

No idea. But maybe the version of black or config for black is more relaxed now at ESCOMP. I've fixed the extra lines, so now it passes.