search

NorESMhub / NorESM

Norwegian Earth System Model and Documentation
https://noresm-docs.readthedocs.io/en/latest/
Other
35 stars 74 forks source link

Remove preprocessorDefinitions.h files #498

Closed gold2718 closed 10 months ago

gold2718 commented 10 months ago

preprocessor files such as preprocessorDefinitions.h should not be used. These files have been removed (there were all in cime_config/usermods_dirs). Where the preprocessorDefinitions.h file defined the AEROCOM preprocessor symbol, this behavior was restored by adding ./xmlchange AEROCOM=TRUE to a shell_commands file in the same usermod.

Run tests to see if these compsets build sucessfully?

mvertens commented 10 months ago

@gold2718 - the xml change command needs to be ./xmlchange CAM_AEROCOM=TRUE not ./xmlchange AEROCOM=TRUE I did not catch this as well until I tried to build a test. Could you please update the two places and I'll test again.

mvertens commented 10 months ago

I have verified that with the changes to AEROCOM=>CAM_AEROCOM creating cases for cmip6_noresm_hifreq_xaer and cmip6_noresm_xaer work correctly. The other user-mods also have CAM_AEROCOM=FALSE