updates to noresm_develop to be close as possible to noresm2_3_develop

[mvertens]

This PR updates the oslo_aero code base so that there are minimal differences between the branches noresm_develop and noresm2_3_develop.

The only files that are different between the two in src/ are:

oslo_aero_control.F90 
oslo_aero_nucleate_ice.F90 
oslo_aero_optical_params.F90 

This PR also resolved Issue #12 which now passes.

[oyvindseland]

Does this mean that the SE dycore also works in a 2.3 setting with Oslo-Aero or is it the development version pointing towards 2.5?

[mvertens]

@oyvindseland - there are two development branches of oslo-aero. One that goes into 2.3 and one that goes into 2.5. The actual oslo-aero code (in src/) is almost the same between the two except for one file with major differences. The shadow files (in src_cam/) are somewhat different - which is to be expected. You should be able to run the spectral element in 2.3 - but its not officially supported in that version. So @gold2718 will be extending the noresm2_3_develop branch of oslo-aero for the noresm2.3 release and I will be working on the noresm2_5_develop version for noresm2.5. Does this help clarify things?

[oyvindseland]

OK. Good to know

[mvertens]

@gold2718 - so I'm holding off a bit on this PR since the threading seems to be broken (ERP test crashes). I'm trying to track down if its the oslo_aero code or not. The PEM test passes. I'll raise issues once I sort this out.