search

NorESMhub / noresm2cmor

A command line tool for cmorizing NorESM output
http://noresmhub.github.io/noresm2cmor/
5 stars 16 forks source link

[BUG] Error in AERmon variables #272

Closed oyvindseland closed 3 years ago

oyvindseland commented 3 years ago

Error in AERmon variables dryss and dryoa. Must be retracted and republished. Not all output fields included. dryso4 and drybc correct.

Simulations: AerChemMIP, RFMIP and CMIP

Corrected in the table but also included here

dryss: SS_A1DDF + SS_A2DDF + SS_A3DDF +SS_A1_OCWDDF + SS_A2_OCWDDF + SS_A3_OCWDDF

dryoa: OM_ACDDF + OM_AIDDF + OM_NIDDF +OM_AC_OCWDDF + OM_AI_OCWDDF + OM_NI_OCWDDF

@YanchunHe @DirkOlivie @MichaelSchulzMETNO

DirkOlivie commented 3 years ago

@øyvind

I think we maybe have to change the expression for dryoa and wetoa, and include the contribution from SOA_A1 and SOA_NA dry and wet depostion. In mmroa (which is used by many people to calculate the burden en then the lifetime) SOA_A1 and SOA_NA is included, and therefore I think it should be also included in dryoa and wetoa.

Could you check whether I see this right.

oyvindseland commented 3 years ago

@DirkOlivie

Yes you are right. the secondary organic aerosols should also be included.

YanchunHe commented 3 years ago

OK, so then, the dryoa is: OM_ACDDF + OM_AIDDF + OM_NIDDF +OM_AC_OCWDDF + OM_AI_OCWDDF + OM_NI_OCWDDF + SOA_A1 + SOA_NA ;

and the wetoa is: OM_ACSFWET+OM_AISFWET+OM_NISFWET+OM_AC_OCWSFWET+OM_AI_OCWSFWET+OM_NI_OCWSFWET+SOA_A1 + SOA_NA

??

Could you also go through the whole CMIP6_AERmon table variables, to check if others are correct (except for those dry dust, wetdust, dryss, dryoa, which has been corrected by not committed).

See the current list of supported variables of AERmon in https://github.com/NorESMhub/noresm2cmor/blob/master/namelists/var_CMIP6_NorESM2_default.nml

Not there are some duplicated entries of the same CMIP6 variable names, for example, dryso4. The last will override if both exist. Please let me know if you are sure that one of such option can be removed fro the var_*.nml file.

DirkOlivie commented 3 years ago

@YanchunHe

dryoa should be : OM_ACDDF + OM_AIDDF + OM_NIDDF +OM_AC_OCWDDF + OM_AI_OCWDDF + OM_NI_OCWDDF + SOA_A1DDF + SOA_NADDF + SOA_A1_OCWDDF + SOA_NA_OCWDDF

wetoa should be : OM_ACSFWET+OM_AISFWET+OM_NISFWET+OM_AC_OCWSFWET+OM_AI_OCWSFWET+OM_NI_OCWSFWET + SOA_A1SFWET + SOA_NASFWET + SOA_A1_OCWSFWET + SOA_NA_OCWSFWET

I'll try to have a look at the other variables too.

DirkOlivie commented 3 years ago

@YanchunHe @oyvindseland

Another issue is that in all the cmorized wet-deposition fields for aerosols (wetoa, wetso4, wetbc, wetss, wetdst) the values are negative, whereas they are positive for the dry deposition fields. This is because the raw aerosol wet-depostion fields are negative in NorESM. Maybe we should also correct that.

YanchunHe commented 3 years ago

@YanchunHe @oyvindseland

Another issue is that in all the cmorized wet-deposition fields for aerosols (wetoa, wetso4, wetbc, wetss, wetdst) the values are negative, whereas they are positive for the dry deposition fields. This is because the raw aerosol wet-depostion fields are negative in NorESM. Maybe we should also correct that.

Thanks! So we need to make all of those above aerosols positive sign? (absolute values)

And also please review other AERmon fields, so that I can proceed, and republish them together with other fixes.

We would better do this at once.

DirkOlivie commented 3 years ago

Hi @YanchunHe ,

shall I change the table https://docs.google.com/spreadsheets/d/1-XOmrpOewOJ4msZ2cuQ41NRiMKgMZ5BfiNeAAFUsp3M/edit#gid=251590531 with the following modifications :

YanchunHe commented 3 years ago

Yes, please do that! @DirkOlivie Thanks! If there is not other changes for the AERmon variables, I will proceed with the cmorization and publishing.

DirkOlivie commented 3 years ago

@YanchunHe I have now updated in the table the description of

YanchunHe commented 3 years ago

@DirkOlivie

These mentioned data are processed under /projects/NS9034K/CMIP6/.cmorout/NorESM2-LM/historical/v20210319,

Could you have a look if they looks OK?

I also attached some global-averaged time series plots of these fields:

YanchunHe commented 3 years ago

@monsieuralok

Could you retract all dryss and dryoa and wetoa variables of AERmon table for all experiments. Thanks!

I will recmorize some of them and republish.

MichaelSchulzMETNO commented 3 years ago

@YanchunHe Havent you recalculated all these: wetoa, wetso4, wetbc, wetss, wetdust, dryoa Shouldnt all these from all experiments be recomputed, retracted and republished then?

MichaelSchulzMETNO commented 3 years ago

By the way, I had checked the new wetoa and dryoa , compared to Gliss et al 2020 paper, and they seemed to be correct now.

YanchunHe commented 3 years ago

Havent you recalculated all these: wetoa, wetso4, wetbc, wetss, wetdust, dryoa

Yes, I am doing this right now, and will be ready to be republished the next week.

@MichaelSchulzMETNO

DirkOlivie commented 3 years ago

@YanchunHe I have checked the wetss, wetdust, wetso4, wetbc, wetoa and dryoa and they seem ok.

monsieuralok commented 3 years ago

@monsieuralok

Could you retract all dryss and dryoa and wetoa variables of AERmon table for all experiments. Thanks!

I will recmorize some of them and republish.

@YanchunHe do we need to remove all data from all experiments from NorESM2-LM and NorESM-MM ? or only NorESM2-LM?

YanchunHe commented 3 years ago

Datasets have been recmorized for the above-referred datasets (mainly CMIP and ScenarioMIP experiments) and are now in the queue to be republished to ESGF.

I close the issue now, and reopen when necessary.

Relates to commit: c4d6aa1

monsieuralok commented 3 years ago

@YanchunHe do we need to remove all data from all experiments from NorESM2-LM and NorESM-MM ? or only NorESM2-LM? Please could you reply regarding that?

YanchunHe commented 3 years ago

@YanchunHe do we need to remove all data from all experiments from NorESM2-LM and NorESM-MM ? or only NorESM2-LM? Please could you reply regarding that?

Yes, please retract all the following dataset for all experiments, for both LM and MM

And retract all the dataset of the following for CMIP and ScenarioMIp for LM and MM.

(21/April, 2021, a correction: wetdst should be wetdust).

monsieuralok commented 3 years ago

@YanchunHe if I am correct for only AERmon frequency?

YanchunHe commented 3 years ago

Yes, I think they are only available in the AERmon frequency.

monsieuralok commented 3 years ago

@YanchunHe do we need to remove all data from all experiments from NorESM2-LM and NorESM-MM ? or only NorESM2-LM? Please could you reply regarding that?

Yes, please retract all the following dataset for all experiments, for both LM and MM

* dryss, dryoa, wetoa

And retract all the dataset of the following for CMIP and ScenarioMIp for LM and MM.

* wetso4, wetbc, wetss, wetdst

@YanchunHe If I am correct wetdst is not published already for any experiments?

YanchunHe commented 3 years ago

You are right @monsieuralok , wetdust was not cmorized and published before.

(note a typo of wetdst, should be wetdust. I correct this in the above comments)

monsieuralok commented 3 years ago

You are right @monsieuralok , wetdust was not cmorized and published before.

(note a typo of wetdst, should be wetdust. I correct this in the above comments)

@YanchunHe but, wetdust also does not exist for atleast NorESM2-LM and NorESM-MM in previously published experiment for CMIP and ScenarioMIP?

YanchunHe commented 3 years ago

Yes, your are right. wetdust does not exist for any previously published datasets.

(Sorry for the confusion, the 'auto-correction' of the keyboard input makes a lot of 'typos' for non-dictionary words.)

MichaelSchulzMETNO commented 3 years ago

drydust and wetdust should be published on all experiments indeed, where the output was saved.

YanchunHe commented 3 years ago

It is now only cmorized for CMIP and ScenarioMIP.

Can be quite a bit work to cmorize and publish all experiments.

But Alok and I can arrange that if this is necessary.

@monsieuralok Alok, do you find it is OK to publish data for all experiments?

MichaelSchulzMETNO commented 3 years ago

Ok, priority would be to do also AerChemMIP and RFMIP experiments, please. All deposition data are useful here.

monsieuralok commented 3 years ago

@YanchunHe @MichaelSchulzMETNO I can start to publish already data those are CMORised. Today, my most time gone with ESGF server issues. But, all the open issues I will publish tomorrow.

YanchunHe commented 3 years ago

Thank you for the clarifying, @MichaelSchulzMETNO

Sure, we can cmorize and publish AerChemMIP and RFMIP for this.

And if there are need for some other MIP, please point to us here. Thanks!

Yanchun

monsieuralok commented 3 years ago

@YanchunHe unpublished finally!!!