NorESMhub / noresm2cmor

A command line tool for cmorizing NorESM output
http://noresmhub.github.io/noresm2cmor/
5 stars 16 forks source link

[ERROR] Inconsistent longitude bounds in PIControl NorESM2-LM #323

Open Ovewh opened 2 years ago

Ovewh commented 2 years ago

Describe the error The longitude bounds are not consistent within the PIControl cmorized output. The output from the beginning of PIControl has different longitude bounds compared to the end of PIControl. E.g: CMIP6/CMIP/NCC/NorESM2-LM/piControl/r1i1p1f1/Amon/ps/gn/v20210118/ps_Amon_NorESM2-LM_piControl_r1i1p1f1_gn_206101-207012.nc and CMIP6/CMIP/NCC/NorESM2-LM/piControl/r1i1p1f1/Amon/ps/gn/v20210118/ps_Amon_NorESM2-LM_piControl_r1i1p1f1_gn_160001-160912.nc

Way to correct Describe which has correctly described longitude bounds

YanchunHe commented 1 year ago

Now I find this was impacted by a commit, 76311689f9e1278cd1cbe0a1722d5a25c7540802 on 21 August 2019.

Datasets published after that (21st August 2019) should be the correct number. Except for the version v20211108, which is special as it is a retract and republish instead of cmorized new datasets.

More specifically, for the piControl, datasets from 1600-1900 were cmorized before 21 August 2019, and 1901-2100 were comrized later. All of them are retracted and republished as version 20211108.

So for piControl, the lon_bnds in ps are correct for years 1901-2100.

Alok, @monsieuralok, could you report an erratum that lon_bnds are correct after datasets version v20190920 are correct. (except for version v20210108, which depends on the actual version when it was first cmorized).

the 'longitude' is:

 lon = 0, 2.5, 5, 7.5, 10, 12.5, 15, 17.5, 20, 22.5, 25, 27.5, 30, 32.5, 35,
    37.5, 40, 42.5, 45, 47.5, 50, 52.5, 55, 57.5, 60, 62.5, 65, 67.5, 70,
    72.5, 75, 77.5, 80, 82.5, 85, 87.5, 90, 92.5, 95, 97.5, 100, 102.5, 105,
    107.5, 110, 112.5, 115, 117.5, 120, 122.5, 125, 127.5, 130, 132.5, 135,
    137.5, 140, 142.5, 145, 147.5, 150, 152.5, 155, 157.5, 160, 162.5, 165,
    167.5, 170, 172.5, 175, 177.5, 180, 182.5, 185, 187.5, 190, 192.5, 195,
    197.5, 200, 202.5, 205, 207.5, 210, 212.5, 215, 217.5, 220, 222.5, 225,
    227.5, 230, 232.5, 235, 237.5, 240, 242.5, 245, 247.5, 250, 252.5, 255,
    257.5, 260, 262.5, 265, 267.5, 270, 272.5, 275, 277.5, 280, 282.5, 285,
    287.5, 290, 292.5, 295, 297.5, 300, 302.5, 305, 307.5, 310, 312.5, 315,
    317.5, 320, 322.5, 325, 327.5, 330, 332.5, 335, 337.5, 340, 342.5, 345,
    347.5, 350, 352.5, 355, 357.5 ;

and the boundaries:

lon_bnds =
  -1.25, 1.25,
  1.25, 3.75,
  3.75, 6.25,
  6.25, 8.75,
  8.75, 11.25,
  11.25, 13.75,
  13.75, 16.25,
  16.25, 18.75,
  18.75, 21.25,
  21.25, 23.75,
  23.75, 26.25,
  26.25, 28.75,
  28.75, 31.25,
  31.25, 33.75,
  33.75, 36.25,
  36.25, 38.75,
  38.75, 41.25,
  41.25, 43.75,
  43.75, 46.25,
  46.25, 48.75,
  48.75, 51.25,
  51.25, 53.75,
  53.75, 56.25,
  56.25, 58.75,
  58.75, 61.25,
  61.25, 63.75,
  63.75, 66.25,
  66.25, 68.75,
  68.75, 71.25,
  71.25, 73.75,
  73.75, 76.25,
  76.25, 78.75,
  78.75, 81.25,
  81.25, 83.75,
  83.75, 86.25,
  86.25, 88.75,
  88.75, 91.25,
  91.25, 93.75,
  93.75, 96.25,
  96.25, 98.75,
  98.75, 101.25,
  101.25, 103.75,
  103.75, 106.25,
  106.25, 108.75,
  108.75, 111.25,
  111.25, 113.75,
  113.75, 116.25,
  116.25, 118.75,
  118.75, 121.25,
  121.25, 123.75,
  123.75, 126.25,
  126.25, 128.75,
  128.75, 131.25,
  131.25, 133.75,
  133.75, 136.25,
  136.25, 138.75,
  138.75, 141.25,
  141.25, 143.75,
  143.75, 146.25,
  146.25, 148.75,
  148.75, 151.25,
  151.25, 153.75,
  153.75, 156.25,
  156.25, 158.75,
  158.75, 161.25,
  161.25, 163.75,
  163.75, 166.25,
  166.25, 168.75,
  168.75, 171.25,
  171.25, 173.75,
  173.75, 176.25,
  176.25, 178.75,
  178.75, 181.25,
  181.25, 183.75,
  183.75, 186.25,
  186.25, 188.75,
  188.75, 191.25,
  191.25, 193.75,
  193.75, 196.25,
  196.25, 198.75,
  198.75, 201.25,
  201.25, 203.75,
  203.75, 206.25,
  206.25, 208.75,
  208.75, 211.25,
  211.25, 213.75,
  213.75, 216.25,
  216.25, 218.75,
  218.75, 221.25,
  221.25, 223.75,
  223.75, 226.25,
  226.25, 228.75,
  228.75, 231.25,
  231.25, 233.75,
  233.75, 236.25,
  236.25, 238.75,
  238.75, 241.25,
  241.25, 243.75,
  243.75, 246.25,
  246.25, 248.75,
  248.75, 251.25,
  251.25, 253.75,
  253.75, 256.25,
  256.25, 258.75,
  258.75, 261.25,
  261.25, 263.75,
  263.75, 266.25,
  266.25, 268.75,
  268.75, 271.25,
  271.25, 273.75,
  273.75, 276.25,
  276.25, 278.75,
  278.75, 281.25,
  281.25, 283.75,
  283.75, 286.25,
  286.25, 288.75,
  288.75, 291.25,
  291.25, 293.75,
  293.75, 296.25,
  296.25, 298.75,
  298.75, 301.25,
  301.25, 303.75,
  303.75, 306.25,
  306.25, 308.75,
  308.75, 311.25,
  311.25, 313.75,
  313.75, 316.25,
  316.25, 318.75,
  318.75, 321.25,
  321.25, 323.75,
  323.75, 326.25,
  326.25, 328.75,
  328.75, 331.25,
  331.25, 333.75,
  333.75, 336.25,
  336.25, 338.75,
  338.75, 341.25,
  341.25, 343.75,
  343.75, 346.25,
  346.25, 348.75,
  348.75, 351.25,
  351.25, 353.75,
  353.75, 356.25,
  356.25, 358.75 ;
}
adagj commented 1 year ago

Hi, I think this is already discussed in https://github.com/NorESMhub/noresm2cmor/issues/310 I think an errata was made?

https://errata.es-doc.org/static/view.html?uid=e3bb30f7-b863-8731-b967-99515894b93a

YanchunHe commented 1 year ago

Thanks @adagj for pointing out. I was searching the previous issue but did not pop up the right one.

Anyway, it is now clearer that all datasets before and including v20190815 have likely wrong values. Datasets after v20190920 should be correct, except for version v20210108, which is a republishing all previously existing datasets.

Alok, is it possible to update the Errata to include the dataset version information? @monsieuralok