Open GoogleCodeExporter opened 9 years ago
Thanks for logging it, do you mean implement the previous version?
Original comment by JamesLuo...@gmail.com
on 17 May 2010 at 11:19
James:
I don't know how previous version was. I'm talking specifically about class
HTMLTemplatePanel. These are my suggestions:
- HTMLTemplatePanel should have a setter of property uiBinderManager.
- My implementation of UIBinderManager will manage validation constraints of
type
InvalidConstraint<Object> instead of ConstraintViolation.
- And ... like a bonus ... mmmm ... I don't know the word in english...
HTMLTemplatePanel should not have methods like validate returning sets of
ConstraintViolation<Object>. validate method should return Set, without
specifying
type. This could allow me to add my OWN implementation of UIBinderManager with
my own
custom validators.
What do you think ? It is a good idea ?
I wrote my own MyHTMLTemplatePanel, but precompiler of gwt doesn't create my
default
constructor. I have started gwt two weeks ago.
Best regards
Original comment by demostenes1509
on 18 May 2010 at 4:39
Yes, We can do this together. Do you mind become a committer of this project.
And what version are you using? Direct from SVN? cause I have a big change to
make it
ready to release 1.0, if you are not working from SVN version, I'm afraid you
will
change you code after 1.0 release.
Original comment by JamesLuo...@gmail.com
on 18 May 2010 at 5:06
James, I'd love to become a commiter, but I don't know how the process is. When
I get
home tonight, I will read wiki in order to start working with it.
Original comment by demostenes1509
on 18 May 2010 at 6:37
[deleted comment]
James:
I didn't found how to become a commiter. Would you mind helping me with that ?
- I have one or two ideas to contribute.
- First at all, add generic validation to gwt-ent,
- Second.... mavenize the project !!
Best regards.
Max
Original comment by demostenes1509
on 19 May 2010 at 6:54
Hi, Max, I had made that change, have you receive email or not? you are list in
the
committer list now.
It's better you can check out all code cause that's the newest one! the package
structure is totally different with 0.7 release.
Regards
James
Original comment by JamesLuo...@gmail.com
on 19 May 2010 at 7:10
[deleted comment]
[deleted comment]
Hi, James ! I had take a look on new code.... and I think it is great !! But (
always
appears a but ) it is still coupled with ConstraintViolation annotation. All
Sets of
DataBinder should be Set without type ( It will guarantee Hibernate developers
can
use it ). Unfortunately, a lot of market share still uses Hibernate without JPA.
In other term of things, I will start adding maven support to project, because
it
will allow us to add .jars to maven repositories ( Maven it is currently a
standard
). It is ok for you ?
Best regards !
P.S. If you want to, I can add a folder with my maven version of all modules, in
order to leave clean your development. When I finish, we can migrate all code to
maven version in one shot.
Original comment by demostenes1509
on 19 May 2010 at 2:23
James, My name is Mariano and I work with Max. Max commented the possibility to
become a commiter of this project.
I'm very interested for the same reasons that Max already explained. Is there
the
possibility that you give me commiter access to the project?
Thank you.
Original comment by mvid...@gmail.com
on 19 May 2010 at 4:32
Hi, Mariano, That's great, I had added you to the committer list, Thank you
very much.
Best Regards
James
Original comment by JamesLuo...@gmail.com
on 20 May 2010 at 12:43
Hi, Max
Yes, the code hasn't change yet. Only package structure changed as I separated
GWTENT to different modules.
Add to maven is a great idea, Thank you for your work !
Add a new folder is a good idea too :)
I will look into Hibernate annotations tomorrow, we will found a best solution for it.
Best Regards
James
Original comment by JamesLuo...@gmail.com
on 20 May 2010 at 12:51
James:
I've added a new folder to svn, gwt.parent, which has gwtent and gwtent_app
submodules. Both of them compiles in Eclipse, but gwtent doesn't compile in
prompt.
Im using java 1.6 ( because Java 1.5 has no longer support ).
Tonight I will change gwt xml config file from src/main/resources to
src/main/java, and I will continue adding projects to maven. Mariano will fix
some
maven issues too. If you need some help to import and configure project, I can
add a
readme.txt to parent pom in project.
Best regards.
Original comment by demostenes1509
on 20 May 2010 at 8:00
Original issue reported on code.google.com by
demostenes1509
on 17 May 2010 at 3:28