Norbyte / bg3se

Baldur's Gate 3 Script Extender
Other
1.09k stars 68 forks source link

Missing Chinese Characters #427

Open Jie-yang-1014 opened 1 month ago

Jie-yang-1014 commented 1 month ago

I have attempted solutions to common problems

Yes

I have checked that my game version is supported

Yes

OS

Windows 11

Platform

Steam

Description

I'm translating a mod Mark Books As Read which support MCM to chinese, and I find some chinese characters are displayed as "?" : PixPin_2024-07-31_09-45-39

After doing some research, I think the problem is due to this piece of code: line 1474 of bg3se/BG3Extender/Extender/Client/IMGUI/IMGUI.cpp: PixPin_2024-07-31_18-14-41

For glyphRanges, there is difference between the two:

io.Fonts->GetGlyphRangesChineseSimplifiedCommon(); // This one only loads 2500 chinese characters referring to the Wikipedia, and it's missing many chinese characters.

io.Fonts->GetGlyphRangesChineseFull(); // This one loads all the chinese characters in the font

Maybe you can change the glyphRanges in "Chinese" section to "io.Fonts->GetGlyphRangesChineseFull(); " ?

Indications

No response

Diagnostic Files

No response

Steps to Reproduce

No response

Expected Behavior

No response

Actual Behavior

No response

Norbyte commented 3 weeks ago

Hi,

The glyph ranges will be extended to the full range for the Chinese locale as well in v19.