Open cosmodiskan opened 8 months ago
From poking around, it looks like what is needed is the contents of C:\Program Files\dotnet\sdk\8.0.101 (or whatever 8.0 subversion, and assuming x64 install) extracted to remove all directory structure, and then copied (or at least partially copied) to numerous folders.
Suggest adjusting readme to specify extraction method of files from SDK to a single folder in \External\ and then adjusting the make to pull the .net stuff from there, instead of a bunch of different places.
After having manually collected the .net SDK files and placing them in the correct place, attempting make functions.
However, attempting to build the project fails, as the project files refer to files that are not in the repo.
`PS D:\Documents\2024\lslib-master>
>> dotnet build -c Release
MSBuild version 17.8.3+195e7f5a3 for .NET
C:\Program Files\dotnet\sdk\8.0.101\NuGet.targets(399,5): error MSB3202: The project file "D:\Documents\2024\lslib-master\LSLibSearch\LSLibSearch.csproj" was not found. [D:\Documents\2024\lslib-master\LSTools.sln]
C:\Program Files\dotnet\sdk\8.0.101\NuGet.targets(399,5): error MSB3202: The project file "D:\Documents\2024\lslib-master\LSLibSearchIndexer\LSLibSearchIndexer.csproj" was not found. [D:\Documents\2024\lslib-master\LSTools.sln]
D:\Documents\2024\lslib-master\StatFastParser\StatFastParser.csproj : error MSB4025: The project file could not be loaded. Could not find a part of the path 'D:\Documents\2024\lslib-master\StatFastParser\StatFastParser.csproj'.
Build FAILED.
C:\Program Files\dotnet\sdk\8.0.101\NuGet.targets(399,5): error MSB3202: The project file "D:\Documents\2024\lslib-master\LSLibSearch\LSLibSearch.csproj" was not found. [D:\Documents\2024\lslib-master\LSTools.sln]
C:\Program Files\dotnet\sdk\8.0.101\NuGet.targets(399,5): error MSB3202: The project file "D:\Documents\2024\lslib-master\LSLibSearchIndexer\LSLibSearchIndexer.csproj" was not found. [D:\Documents\2024\lslib-master\LSTools.sln]
D:\Documents\2024\lslib-master\StatFastParser\StatFastParser.csproj : error MSB4025: The project file could not be loaded. Could not find a part of the path 'D:\Documents\2024\lslib-master\StatFastParser\StatFastParser.csproj'.
0 Warning(s)
3 Error(s)
Time Elapsed 00:00:00.45`
``
Attempting to build individual apps (Such as the ConverterApp that is the primary application I want to play around with) fails as well. Example below.
``
`D:\Documents\2024\lslib-master\ConverterApp>dotnet build -c Release --no-restore
MSBuild version 17.8.3+195e7f5a3 for .NET
D:\Documents\2024\lslib-master\ConverterApp\ConverterApp.csproj : error NU1100: Unable to resolve 'System.Data.DataSetExtensions (>= 4.5.0)' for 'net8.0-windows7.0'.
D:\Documents\2024\lslib-master\ConverterApp\ConverterApp.csproj : error NU1100: Unable to resolve 'Newtonsoft.Json (>= 13.0.3)' for 'net8.0-windows7.0'.
D:\Documents\2024\lslib-master\ConverterApp\ConverterApp.csproj : error NU1100: Unable to resolve 'OpenTK.Mathematics (>= 4.8.2)' for 'net8.0-windows7.0'.
D:\Documents\2024\lslib-master\ConverterApp\ConverterApp.csproj : error NU1100: Unable to resolve 'lz4net (>= 1.0.15.93)' for 'net8.0-windows7.0'.
D:\Documents\2024\lslib-master\ConverterApp\ConverterApp.csproj : error NU1100: Unable to resolve 'System.IO.Hashing (>= 8.0.0)' for 'net8.0-windows7.0'.
D:\Documents\2024\lslib-master\ConverterApp\ConverterApp.csproj : error NU1100: Unable to resolve 'ZstdSharp.Port (>= 0.7.4)' for 'net8.0-windows7.0'.
Build FAILED.
D:\Documents\2024\lslib-master\ConverterApp\ConverterApp.csproj : error NU1100: Unable to resolve 'System.Data.DataSetExtensions (>= 4.5.0)' for 'net8.0-windows7.0'.
D:\Documents\2024\lslib-master\ConverterApp\ConverterApp.csproj : error NU1100: Unable to resolve 'Newtonsoft.Json (>= 13.0.3)' for 'net8.0-windows7.0'.
D:\Documents\2024\lslib-master\ConverterApp\ConverterApp.csproj : error NU1100: Unable to resolve 'OpenTK.Mathematics (>= 4.8.2)' for 'net8.0-windows7.0'.
D:\Documents\2024\lslib-master\ConverterApp\ConverterApp.csproj : error NU1100: Unable to resolve 'lz4net (>= 1.0.15.93)' for 'net8.0-windows7.0'.
D:\Documents\2024\lslib-master\ConverterApp\ConverterApp.csproj : error NU1100: Unable to resolve 'System.IO.Hashing (>= 8.0.0)' for 'net8.0-windows7.0'.
D:\Documents\2024\lslib-master\ConverterApp\ConverterApp.csproj : error NU1100: Unable to resolve 'ZstdSharp.Port (>= 0.7.4)' for 'net8.0-windows7.0'.
0 Warning(s)
6 Error(s)
Time Elapsed 00:00:00.45
`
Full detailed compile attempt attached as it is too long to include via text. PS DDocuments2024lslib-master.txt
Current readme\make instructions specify downloads of external prerequisites, but do not appear to cover .net prereqs. Attempting to make via make-release.bat indicates numerous files related to .net versions are not present in the package. Given inability to redistribute these MS files, that makes sense, but the instructions should include the download\install\copy instructions for .net prerequesites so a first-time user can successfully make the app.
Ideal solution would include instructions on pre-req install, and provided .bat\script that copies relevant files from original .net install location(s) to location needed for lslib-master to function.
Additionally, current requirements from README do not specify exact path extraction should go to. I expect this is likely something like \External\gplex\binaries , but the default option when extracting the linked .zip files would actually include version number, resulting in something like \External\gplex\gplex-distro-1_2_2\binaries. Clarifying intended structure will help prevent future users from encountering make errors.
Output of make-release on a clean system: