NordMagnus / Trello-Folds

MIT License
19 stars 4 forks source link

Plugin is completely Broken on Mac and Windows #72

Closed carlosgranada closed 2 years ago

carlosgranada commented 2 years ago

I think trello updated the content because the plugin stopped working. The redraw button is no longer visible. The lists disappear when they are collapsed, the only thing that is visible is the number of cards per list.

A sad day 🥲

Screen Shot 2021-11-03 at 2 10 27 PM Screen Shot 2021-11-03 at 2 07 56 PM Screen Shot 2021-11-03 at 2 04 08 PM
anvaridthe commented 2 years ago

same here ((

itaine commented 2 years ago

Ditto! Completely gone.

leannovators commented 2 years ago

same here! :'(

IanSimpson commented 2 years ago

image

I've had a quick look at this - it's throwing a Javascript error when it's first loading. Appears that not all cards have their name loaded at this point, but the plugin is operating under the assumption that there IS a name, and failing.

image

zach-boyer commented 2 years ago

I've had a quick look at this - it's throwing a Javascript error when it's first loading. Appears that not all cards have their name loaded at this point, but the plugin is operating under the assumption that there IS a name, and failing.

I'm seeing this same issue.

NordMagnus commented 2 years ago

I cannot reproduce this myself. If anyone is willing to give access to a board where they see this that would be helpful.

leannovators commented 2 years ago

Hi, on my Mac, the plugin is completely broken. I could share my screen or whatever you need in order to fix this

On Mon, 29 Nov 2021 at 20:08, Magnus Nord @.***> wrote:

I cannot reproduce this myself. If anyone is willing to give access to a board where they see this that would be helpful.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NordMagnus/Trello-Folds/issues/72#issuecomment-981930537, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP22M5NDIKZE6IF2MPAYTFTUOPFTHANCNFSM5HJSLL6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

NordMagnus commented 2 years ago

trello-folds.zip

Please install the above version manually and see if that fixes anything. It's a bit of a long shot but I have tweaked the initialization and timeouts, retry attempts, etc.

Use the instructions in the second answer to this Stack Overflow question to install, and let me know how it goes:

(In this version I've also got rid of jQuery. Might or might not make a difference.)

anvaridthe commented 2 years ago

Hello Magnus,thank you for all that

when installing the extension its showing an error as you can see in the video

*Re: [NordMagnus/Trello-Folds] Plugin is completely Broken on Mac and Windows (Issue #72) - @. @.>

[image: Mailtrack] https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11& Sender notified by Mailtrack https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11& 21-11-30, 05:06:06 a.m.

On Tue, Nov 30, 2021 at 1:45 AM Magnus Nord @.***> wrote:

trello-folds.zip https://github.com/NordMagnus/Trello-Folds/files/7620704/trello-folds.zip

Please install the above version manually and see if that fixes anything. It's a bit of a long shot but I have tweaked the initialization and timeouts, retry attempts, etc.

Use the instructions in the second answer to this Stack Overflow question https://stackoverflow.com/questions/12452817/is-it-possible-to-create-a-chrome-extension-for-private-distribution-outside-chr to install, and let me know how it goes:

(In this version I've also got rid of jQuery. Might or might not make a difference.)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NordMagnus/Trello-Folds/issues/72#issuecomment-981958757, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWKZVGDG4C7J7SW3E57WFNLUOPJ6VANCNFSM5HJSLL6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Best Regards, Anvar Salvar Managing Director BiznesWebPros LLC

www.bizneswebpros.com

mmslkr commented 2 years ago

I've tried debugging this with a local fork and found the issue to be cards that are covered and not in the visible browser window, see screenshot. 2021-11-30_07h44_20 For these cards, getCardName fails since it has no children. These cards are only loaded completely when in view.

In my local fork, I changed this to work around the issue:

diff --git a/extension/tdom.js b/extension/tdom.js
index 9a6ea59..d946dcd 100644
--- a/extension/tdom.js
+++ b/extension/tdom.js
@@ -671,7 +671,7 @@ const tdom = (function (factory) {
             }
             let $span = $card.find("span.list-card-title");
             if ($span.length === 0) {
-                return;
+                return "";
             }
             let title = $card.find("span.list-card-title")
                 .clone() //clone the element

but I don't know if that breaks other functionality I don't use.

leannovators commented 2 years ago

Sorry, I did not manage to follow the steps stated in the Stackoverflow entry due to I do not have the manifest.json file. Where could I get it?

El 29 nov 2021 20:45:46, Magnus Nord @.***> escribió:

trello-folds.zip https://github.com/NordMagnus/Trello-Folds/files/7620704/trello-folds.zip

Please install the above version manually and see if that fixes anything. It's a bit of a long shot but I have tweaked the initialization and timeouts, retry attempts, etc.

Use the instructions in the second answer to this Stack Overflow question https://stackoverflow.com/questions/12452817/is-it-possible-to-create-a-chrome-extension-for-private-distribution-outside-chr to install, and let me know how it goes:

(In this version I've also got rid of jQuery. Might or might not make a difference.)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NordMagnus/Trello-Folds/issues/72#issuecomment-981958757, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP22M5KPWRMDPXKHV52BDHLUOPJ6VANCNFSM5HJSLL6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

NordMagnus commented 2 years ago

Sorry, I did not manage to follow the steps stated in the Stackoverflow entry due to I do not have the manifest.json file. Where could I get it?

You should only follow the instructions under "TO INSTALL":

NordMagnus commented 2 years ago

Hello Magnus,thank you for all that when installing the extension its showing an error as you can see in the video

Hmm... I thought it would work for sure. Found some clues in this thread.

Please ensure you have dev mode enabled. Restart Chrome. Then try to install and see if the error message persists.

leannovators commented 2 years ago

Sorry, but it did not ask for permissions at all when dragging the CRX file on the extensions page… that’s the reason I tried the other way. In fact the extension is installed but:

Sorry, it is in Spanish but it says: This extension does not appear in the Chrome Web Store and it could be damaged without your knowledge. I can not activate it

El 30 nov 2021 17:18:55, Magnus Nord @.***> escribió:

Sorry, I did not manage to follow the steps stated in the Stackoverflow entry due to I do not have the manifest.json file. Where could I get it?

You should only follow the instructions under "TO INSTALL":

  • To install the extension, just get each user to manually drag the newly created extension crx into the Extensions page (chrome://extensions/).
  • The first time it will ask for permissions just like when installing from the Chrome Web Store.
  • For each new version, as long as you used the same private key file for each new version, users just drag the new version into the Extensions page the same way except they won't be asked for permissions again. It will just update the extension.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NordMagnus/Trello-Folds/issues/72#issuecomment-982792493, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP22M5NRE5ZPGWAJ5DED47LUOT2O7ANCNFSM5HJSLL6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

anvaridthe commented 2 years ago

Hey,

dont wanna be like an a**hole here but for now you can use "collapsible trello lists" extension. its not as good as trello folds but its ok to use until trello folds is fixed

cheers

On Tue, Nov 30, 2021 at 11:22 PM LEANNOVATORS.TECH @.***> wrote:

Sorry, but it did not ask for permissions at all when dragging the CRX file on the extensions page… that’s the reason I tried the other way. In fact the extension is installed but:

Sorry, it is in Spanish but it says: This extension does not appear in the Chrome Web Store and it could be damaged without your knowledge. I can not activate it

El 30 nov 2021 17:18:55, Magnus Nord @.***> escribió:

Sorry, I did not manage to follow the steps stated in the Stackoverflow entry due to I do not have the manifest.json file. Where could I get it?

You should only follow the instructions under "TO INSTALL":

  • To install the extension, just get each user to manually drag the newly created extension crx into the Extensions page (chrome://extensions/).
  • The first time it will ask for permissions just like when installing from the Chrome Web Store.
  • For each new version, as long as you used the same private key file for each new version, users just drag the new version into the Extensions page the same way except they won't be asked for permissions again. It will just update the extension.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/NordMagnus/Trello-Folds/issues/72#issuecomment-982792493 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AP22M5NRE5ZPGWAJ5DED47LUOT2O7ANCNFSM5HJSLL6Q

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NordMagnus/Trello-Folds/issues/72#issuecomment-982851746, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWKZVGEQW2PUDO33PLPCRPDUOUB5ZANCNFSM5HJSLL6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Best Regards, Anvar Salvar Managing Director BiznesWebPros LLC

www.bizneswebpros.com

[image: Mailtrack] https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11& Sender notified by Mailtrack https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11& 21-12-01, 01:09:08 a.m.

istepanovs commented 2 years ago

Trying to drag the .cx file into the Extensions window results in this Chrome error for me: 1 (Chrome does not allow to enable the extension; the link points here)

Unpacking the .cx file and choosing to "Load unpacked" results in these extension errors for me (granted I have no idea if it should have worked; I am just randomly following instructions from here): 2 3

Following the advice by mmslkr from above (return; -> return "") did not help me (I took the "extension" folder from the repo, changed the line, then loaded it unpacked).

istepanovs commented 2 years ago

I should mention the first time I saw this bug was ~2 days ago, and it's not very consistent. I managed to get the extension to work twice since then. The first time just by leaving the tab open for hours; so not sure what could have passively fixed it. The second time it worked right after a reinstall from the Chrome Web Store - and broke right away when I started spamming CTRL+R to test it.

istepanovs commented 2 years ago

@NordMagnus I can reproduce the buggy behavior by creating 15 empty lists in a new, empty Trello board. For example, here is my dummy Trello account and public board that showcases that: https://trello.com/b/6SkulB5L/trello-folds-test

I need to be logged in and possibly press CTRL+R a couple of times till the bug happens. I could not reproduce the problem by looking at this (public) board while not being logged in.

The login/password for this board are: login: mytrello12123@mailinator.com password: mytrello12123

NordMagnus commented 2 years ago

@istepanovs I will try with your board.

NordMagnus commented 2 years ago

I have uploaded a new version to the store. Please try it and report if anything has changed for better or worse, and report back please :)

In the new version there is a setting for board load timeout. Please try it out too.

istepanovs commented 2 years ago

The new version behaves in largely the same way for me. If I keep spamming CTRL+R, it will load up once in every ~20 attempts. The rest of the time the extension fails to load.

leannovators commented 2 years ago

Now it is working form me on Mac! Thank you for the effort!

El 2 dic 2021 17:03:42, Magnus Nord @.***> escribió:

I have uploaded a new version to the store. Please try it and report if anything has changed for better or worse, and report back please :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NordMagnus/Trello-Folds/issues/72#issuecomment-984766379, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP22M5LLLHRL6TU3SZW56Z3UO6KF5ANCNFSM5HJSLL6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

NordMagnus commented 2 years ago

Did another update (should be published momentarily) with another tweak that at least worked locally when testing.

istepanovs commented 2 years ago

Thanks for the update. The extension loads for me nearly always now. There is an odd occasion when it does not load, but that's very rare and I cannot reproduce it reliably yet.

My view states do not get saved, even though the checkbox is on by default. (It's a minor issue that does not affect usability of the extension much for me.) view-state

I get no "Errors" button in the Extensions tab for Trello Folds. Perhaps some of these error messages in the Console inside the Developer Tools could point at something? This happens upon the extension being loaded:

console-1

This happens when trying to collapse and expand any list:

expand-collapse

NordMagnus commented 2 years ago

@istepanovs I think the viewstate issue might have been related to Issue #73 and in that case hopefully fixed now. Anyhow, if you still have problems please file a new bug.

(The sandbox attribute error is expected I think, see this conversation thread over at Atlassian.