search

NordSecurity / uniffi-bindgen-go

Uniffi bindings generator for Golang
Mozilla Public License 2.0
75 stars 21 forks source link

Support for docstrings #25

Closed dignifiedquire closed 6 months ago

dignifiedquire commented 11 months ago

With https://github.com/mozilla/uniffi-rs/pull/1493 getting close to be merged, I was wondering if there was already a branch that supported docstrings and/or if you are planning to implement this

arg0d commented 11 months ago

All branches in our fork starting with 0.23 support docstrings.

Its just somehow Go got left behind :smiling_face_with_tear:

dignifiedquire commented 10 months ago

@arg0d will you have time to work on this? otherwise I will try to look into adding support

arg0d commented 10 months ago

If you have time to spare, sure! Help would be awesome :)

dignifiedquire commented 10 months ago

first version here: https://github.com/NordSecurity/uniffi-bindgen-go/pull/33

kegsay commented 6 months ago

There seems to be 2 docstring impls now - uniffi 0.26 landed it as well as NordSecurity's fork of uniffi-rs https://github.com/NordSecurity/uniffi-rs?tab=readme-ov-file#ad-hoc-features - are they compatible with each other? If so, if we updated to 0.26 could we drop the uniffi-rs fork?

arg0d commented 6 months ago

Yes, the upstream should have identical docstrings implementation in mozilla/uniffi-rs:v0.26.0.