search

NordSecurity / uniffi-bindgen-go

Uniffi bindings generator for Golang
Mozilla Public License 2.0
65 stars 18 forks source link

Update uniffi to 0.26.0 #40

Open MarquessV opened 5 months ago

MarquessV commented 5 months ago

uniffi is up to version 0.26.0 now. Would be good to have this package updated as well.

arg0d commented 5 months ago

We have no plans to work on this at the moment, but a PR would be welcome.

kegsay commented 3 months ago

@arg0d I'd be interested in picking this up. It looks like there's only 1 breaking change looking at https://github.com/mozilla/uniffi-rs/blob/main/CHANGELOG.md#whats-changed

The rust_future_continuation_callback_set FFI function was removed. rust_future_poll now inputs the callback pointer. External bindings authors will need to update their code.

which feels like it should be a simple change. I'm not confident enough to do this (it seems like the uniffi-rs submodule is a fork?) - can you please give me a quick summary of what would need to be changed? Thanks.

arg0d commented 3 months ago

If you are up for doing this work, you could try to use the upstream v0.26.0 as a submodule first. I think most of changes done in our fork for v0.25.0 are already merged to upstream and released under v0.26.0. I could try to update the fork to v0.26.0 sometime next week, I think there should be minimal or no differences or at all.

tnull commented 3 months ago

Has there been any update on this? We would also be very interested in using the Go bindings generator with UniFFI v0.26, and soon v0.27 support would be nice to have. I'd also be happy to contribute (although neither super experienced with UniFFI internals nor Go, fwiw), but I'm wondering if someone is already actively working on it?