Options appear to be ignored

vorburger commented 3 months ago

I just wanted to let you know that I've (only very briefly, without doing any further debugging) tried this feature out, for https://github.com/google/android-fhir/issues/2481, and it seems to me that the Options to chose the Android SDK version appear to be ignored?

In https://github.com/google/android-fhir/pull/2482 (here) I originally tried:

 "ghcr.io/nordcominc/devcontainer-features/android-sdk:1": {
      "platform": "33",
      "build_tools": "33.0.1"
    }

and in the creation.log it (correctly) noticed:

#16 0.762 Feature       : Android SDK2024-03-15 23:05:49.933Z: 
#16 0.762 Description   : Install Android SDK cmdline-, platform-, and, build-tools
#16 0.762 Id            : ghcr.io/nordcominc/devcontainer-features/android-sdk
#16 0.762 Version       : 1.1.0
#16 0.762 Documentation : 
#16 0.762 Options       :
#16 0.762     PLATFORM="33"2024-03-15 23:05:50.082Z: 
#16 0.762     BUILD_TOOLS="33.0.1"

but then it still installed v34 instead of v33:

[====                                   ] 10% Downloading build-tools_r34-linux.
[=======                                ] 18% Unzipping... android-14/NOTICE.txt

I've noticed that several folks published Dev Container Features for installing the Android SDK, so I'll try out another one. I'm only filing this issue to let you know.

filiphsps commented 3 months ago

Thanks, looks like a simple shell script mistake managed to slip under the radar. I'll take a look at it over the weekend! :)

filiphsps commented 3 months ago

Appears that somebody already had investigated, I'll do a proper check later to verify but it should/might be working now!

filiphsps commented 3 months ago

I just wanted to let you know that I've (only very briefly, without doing any further debugging) tried this feature out, for google/android-fhir#2481, and it seems to me that the Options to chose the Android SDK version appear to be ignored?

In google/android-fhir#2482 (here) I originally tried:
 "ghcr.io/nordcominc/devcontainer-features/android-sdk:1": {
      "platform": "33",
      "build_tools": "33.0.1"
    }
and in the creation.log it (correctly) noticed:
#16 0.762 Feature       : Android SDK2024-03-15 23:05:49.933Z: 
#16 0.762 Description   : Install Android SDK cmdline-, platform-, and, build-tools
#16 0.762 Id            : ghcr.io/nordcominc/devcontainer-features/android-sdk
#16 0.762 Version       : 1.1.0
#16 0.762 Documentation : 
#16 0.762 Options       :
#16 0.762     PLATFORM="33"2024-03-15 23:05:50.082Z: 
#16 0.762     BUILD_TOOLS="33.0.1"
but then it still installed v34 instead of v33:
[====                                   ] 10% Downloading build-tools_r34-linux.
[=======                                ] 18% Unzipping... android-14/NOTICE.txt
I've noticed that several folks published Dev Container Features for installing the Android SDK, so I'll try out another one. I'm only filing this issue to let you know.

I can confirm that it's working now using the configuration you originally tried with!

Sorry about miss there! This devcontainer feature was originally created by me to play a little bit with Compose without having to spin up a full-blown Android environment locally, but there hasn't been too much time available for that, so this ended up mostly lying dormant 😅

Let me know if any other issues arise!

NordcomInc / devcontainer-features

Options appear to be ignored #20