search

NordcomInc / devcontainer-features

Dev Container Features
https://nordcom.io/
MIT License
10 stars 5 forks source link

Option to disable OpenJDK install #28

Open Phaestion opened 1 week ago

Phaestion commented 1 week ago

We typically do Compose Multiplatform development and target both Android and Desktop, and sometimes only desktop. Therefore many times we would already have Java installed in out Dev Container setup via the "Dev Containers Spec Maintainers" feature (https://github.com/devcontainers/features/tree/main/src/java)

It would be great to disable the installation of OpenJDK, I guess the best way would be to do this via an optional setting in the Options of this feature. With the default set so that OpenJDK is installed unless the option is set from the default.

I'm happy to provide a PR to do this too.

filiphsps commented 4 days ago

Hi!

I'm happy to provide a PR to do this too.

PRs are more than welcome ðŸ¤