search

NordeaOSS / devtool

DevTools is an tool which makes it easy to install software on windows machines where the user is not admin. It can be used internally in organisations who wants to control their own repository of tools.
MIT License
9 stars 6 forks source link

Version aligment #2

Closed arkadiuszczapiewskinordea closed 6 years ago

arkadiuszczapiewskinordea commented 6 years ago

In Nordea we have v1.37 of DevTool and here on GitHub it is v1.35. Can we align to v1.37?

holmbech commented 6 years ago

Hi,

Sure. Could you maybe check if there have been any changes in the Nordea version that maybe needs to be updated here?

RocketRunner commented 6 years ago

I will follow up on that!

holmbech commented 6 years ago

Anything new on this one @RocketRunner?

holmbech commented 6 years ago

Whats up @RocketRunner?

RocketRunner commented 6 years ago

the Rocket has landed and is now again within radio reach... :-)

I have compared the differences between the versions

Since the fork the internal version has been updated with: curl-ca-bundle.crt

Since the fork the external version has been: parameterized in regards to nexus and confluence urls

The CA bundle has already been added to the external version, so all in all they should be the same.

RocketRunner commented 6 years ago

The problem is that in some cases the users has another version of CURL in the classpath and when they do it seems to be ignoring the CA bundle.

Therefor we still have -insecure added to the curl command to ignore internal signed certificates

RocketRunner commented 6 years ago

I have Bumped the version to 1.37