search

NordicESMhub / galaxy-tools

Galaxy Tools maintained by NordicESMHub
MIT License
8 stars 6 forks source link

Copernicus Essential Climate Variables for assessing climate variability #23

Closed annefou closed 5 years ago

annefou commented 5 years ago
annefou commented 5 years ago

@bgruening

Hi Björn,

NOT URGENT!!!

Whenever you have time, I would really appreciate to get your inputs/review for this new tool essential_climate_variables. (Learning progress, I made a new branch instead of updating the master branch...).

Thanks.

bgruening commented 5 years ago

(Learning progress, I made a new branch instead of updating the master branch...)

Awesome! :)

I'm a little bit puzzels how the tests can turn green if you don't have a API key here.

annefou commented 5 years ago

So fast! Thanks for all your inputs! That's so helpful to get a review.

The tests are running OK because I added my own API key as an environment variable in travis. If you do not have any API keys, all the tests fail.

bgruening commented 5 years ago

The tests are running OK because I added my own API key as an environment variable in travis. If you do not have any API keys, all the tests fail.

Very nice! :)