search

NordicESMhub / galaxy-tools

Galaxy Tools maintained by NordicESMHub
MIT License
8 stars 6 forks source link

Fix for issue #54 #65

Closed pixalytics closed 5 months ago

pixalytics commented 5 months ago

Hi,

I've started to use the EU Galaxy platform as part of an OGC Open Science Persistent Demonstrator Pilot, and I wanted to use this tool as part of a demonstration workflow. However, what's downloaded within the zip file I'm retrieving from CDS is a NetCDF rather than GRIB file. Looking at the repo issues, I noticed this bug had already been reported under issue #54 So, I'm proposing a fix to that bug.

Best Wishes, Sam

bgruening commented 5 months ago

Welcome @pixalytics!

Can you please bump the version number in https://github.com/NordicESMhub/galaxy-tools/blob/8ee4d5f7bc8ac5fcd4f2d5898fa0856d42c57c1a/tools/c3s/c3s.xml#L1 ... this is important for reproducibility.

pixalytics commented 5 months ago

@bgruening Thanks for the feedback, I've made that change

bgruening commented 5 months ago

The failing tests are linting warnings. Nothing crucial. Lets see what @annefou is saying.

annefou commented 5 months ago

Hi @pixalytics

Thank you so much for fixing this long standing bug. I have to admit I forgot about it. This is really super useful contribution!

pixalytics commented 5 months ago

@annefou Happy to support. We'll be working on developing training material for at least the next few months, so I'll make further suggestions if we find further updates helpful.

bgruening commented 5 months ago

Awesome! Thanks a lot @pixalytics!