NordicHPC / sonar

Tool to profile usage of HPC resources by regularly probing processes using ps.
GNU General Public License v3.0
8 stars 5 forks source link

Fix #149 - Don't print cores and memtotalkib #150

Closed lars-t-hansen closed 3 months ago

bast commented 3 months ago

Is it still work in progress? Should I look at the conflicts and merge?

lars-t-hansen commented 3 months ago

Good question! I think I was planning to test sonar sysinfo more thoroughly first and build up a little infra around that. Currently doing so.

Also, it's a little bit up to you what you need for jobgraph and any other clients you're working on. If it's more convenient for jobgraph (say) to have all the info in one place then I don't need to remove all these fields. Hence the "WDYT" on #149.

lars-t-hansen commented 3 months ago

I think this is good to go, sonar sysinfo works in production here. But you might still consider whether this change is something you want.

bast commented 3 months ago

I will look ASAP (another teaching week ...).

bast commented 3 months ago

Having thought more about it. I agree it's better to leave this out.