search

NordicMRspine / MRINavigator.jl

MIT License
2 stars 0 forks source link

add FFTW version compatibility #47

Closed Laura2305 closed 8 months ago

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.96%. Comparing base (4df1c24) to head (5b5e8b2). Report is 11 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #47 +/- ## ======================================= Coverage 70.96% 70.96% ======================================= Files 9 9 Lines 620 620 ======================================= Hits 440 440 Misses 180 180 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Laura2305 commented 8 months ago

@Alexander, I think we can merge this. The precompilation errors on nightly but there's a PR open on CSV.jl regarding this: https://github.com/JuliaData/CSV.jl/issues/1124

The error they report is the same we get in the CI.

alexjaffray commented 8 months ago

Looks good to me, as long as the error on nightly isn't a result of our programming I think it's alright to merge. I'll approve, you can merge when you like.