search

NordicMuseum / Nordic-Museum-Audio-Guide

An inclusive audio guide for The Nordic Museum
https://nordicmuseum.github.io/Nordic-Museum-Audio-Guide/
MIT License
14 stars 6 forks source link

Return to welcome screen when charging #11

Open Ambrosiani opened 5 years ago

Ambrosiani commented 5 years ago

…might be a way to approach a self-service station at the museum. When charging –> return to language selection/welcome screen.

possible plugin: https://github.com/oojr/react-native-battery

Ambrosiani commented 5 years ago

…I guess this should be its own setting a la ShowTutorialEveryTime.

Ambrosiani commented 5 years ago

reset action added in df23ff6f2d1c2ff8764dceb2a3d7b4edbed403e8

Ambrosiani commented 5 years ago

todo:

Ambrosiani commented 5 years ago

…isCharging is on its way to be implemented in react-native-device-info: https://github.com/react-native-community/react-native-device-info/pull/436

Ambrosiani commented 5 years ago

Available in react-native-device-info from 1.4.0! https://github.com/react-native-community/react-native-device-info#isbatterycharging

Ambrosiani commented 5 years ago

@RubenSandwich almost works now! one remaining problem: we don't want to reset museumMode when triggering a reset. Right now museumMode is reset to false which means the tutorial never appears.

(line 15 –> line 8)

https://github.com/NordicMuseum/Nordic-Museum-Audio-Guide/blob/v2/v2/src/reducers/localization.js

I don't 100 % understand what happens if I mess with initialState or the reset action so I'd prefer it if you do the correction :)

RubenSandwich commented 5 years ago

You don’t need to doubt yourself you understand it correctly. (Or at least as correctly as I understand it.)

Good catch!

I’ll find a better way to figure out the reset latter today.

On Tue, Sep 24, 2019 at 8:49 AM Aron Ambrosiani notifications@github.com wrote:

@RubenSandwich https://github.com/RubenSandwich almost works now! one remaining problem: we don't want to reset museumMode when triggering a reset. Right now museumMode is reset to false which means the tutorial never appears.

(line 15 –> line 8)

https://github.com/NordicMuseum/Nordic-Museum-Audio-Guide/blob/v2/v2/src/reducers/localization.js

I don't 100 % understand what happens if I mess with initialState or the reset action so I'd prefer it if you do the correction :)

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/NordicMuseum/Nordic-Museum-Audio-Guide/issues/11?email_source=notifications&email_token=AAO53Q7CRRBTEMHMNIHFTOTQLIEERA5CNFSM4GQUBP32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7OGJCI#issuecomment-534537353, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO53Q2OM6BECV3QR7V2GY3QLIEERANCNFSM4GQUBP3Q .