search

NordicMuseum / Nordic-Museum-Audio-Guide

An inclusive audio guide for The Nordic Museum
https://nordicmuseum.github.io/Nordic-Museum-Audio-Guide/
MIT License
14 stars 6 forks source link

LTR/RTL language switch not working 100 % #13

Closed Ambrosiani closed 5 years ago

Ambrosiani commented 5 years ago

Users report problems when switching btwn left-to-right and right-to-left languages. Todo: add screenshots here…

Ambrosiani commented 5 years ago

I think that the language setting is (sometimes) not stored correctly when the app is restarted. In the attached example, it reverts to the default phone language about 50 % of the time.

Screen recording

RubenSandwich commented 5 years ago

Thanks for the video @Ambrosiani, did you find any steps that can reproduce it 100% of the time?

Ambrosiani commented 5 years ago

not yet, but will do some more serious testing on the ipods :)

RubenSandwich commented 5 years ago

Thanks so much Aron!

(Also not that you're asking but if you're looking for an easy way to make GIFs so you can just upload it to Github I suggest: https://www.cockos.com/licecap/.)

Ambrosiani commented 5 years ago

on an iphone with Swedish as default locale:

  1. remove app from cache
  2. start app (in Swedish)
  3. switch to Arabic

result: Arabic, LTR: 1 Arabic, RTL: 5 Swedish, RTL: 3 Swedish, LTR: 5

on an iphone with Swedish as default locale & "museum mode"

  1. remove app from cache
  2. start app (in Swedish)
  3. select Arabic in tutorial

result: Arabic, LTR: 0 Arabic, RTL: 6 Arabic, some RTL & some LTR: 1 Swedish, RTL: 0 Swedish, LTR: 4 Swedish, some RTL & some LTR: 1 crashed app: 3

RubenSandwich commented 5 years ago

@Ambrosiani Awesome thanks for the detailed write-up. It's a bit crazy how all over the place this bug is... 😖 I'll look into it a bit next week.

Ambrosiani commented 5 years ago

seems like I18nManager.forceRTL & react-native-restart could be enough. That's how our KTH students implemented it in their android version at least.

some ideas here: https://github.com/facebook/react-native/issues/17867

student code here: https://github.com/NordicMuseum/Nordic-Museum-Audio-Guide-Android/blob/master/app/screens/language.js

Ambrosiani commented 5 years ago

no issues so far in v2 – closing!