search

NordicMuseum / Nordic-Museum-Audio-Guide

An inclusive audio guide for The Nordic Museum
https://nordicmuseum.github.io/Nordic-Museum-Audio-Guide/
MIT License
14 stars 6 forks source link

Setup continuous deployment Github > App Store #19

Closed Ambrosiani closed 5 years ago

Ambrosiani commented 5 years ago

To be described in more detail.

RubenSandwich commented 5 years ago

Using something like https://appcenter.ms? Or just build on TravisCI/CircleCI and https://fastlane.tools.

Ambrosiani commented 5 years ago

Fastlane looks like a good first choice – since we are adding the mp3 files manually we can't move completely into the cloud yet anyway.

RubenSandwich commented 5 years ago

@Ambrosiani One way to completely move to the cloud is for a private repo of the copyrighted mp3's and images living in a private repo and during the CD process, those assets can be placed in the app before building and submitting to the app store. (Both Travis and CircleCI support having secrets, like a GitHub token, in your CI/CD service.) I think we should at least explore this route and try to save you the ~1 hour it takes per release.

Ambrosiani commented 5 years ago
Ambrosiani commented 5 years ago

@RubenSandwich doesn't seem like I can combine assets from multiple repositories. rather, should we push changes from the public repo into the private repo and then build from the private repo?

RubenSandwich commented 5 years ago

Yeah let’s try that.

Can you also contact App Center and see if they will upgrade us because it’s a non-profit?

Ruben

P.S. Is there anyway to run a script before building?

On Fri, Sep 20, 2019 at 12:32 PM Aron Ambrosiani notifications@github.com wrote:

@RubenSandwich https://github.com/RubenSandwich doesn't seem like I can combine assets from multiple repositories. rather, should we push changes from the public repo into the private repo and then build from the private repo?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/NordicMuseum/Nordic-Museum-Audio-Guide/issues/19?email_source=notifications&email_token=AAO53Q42WOGTQERA3YXGQULQKT3LJA5CNFSM4HGKJ5PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7HHNLA#issuecomment-533624492, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO53Q5GZKU6KNJ2NI3S5Q3QKT3LJANCNFSM4HGKJ5PA .

Ambrosiani commented 5 years ago

@RubenSandwich yes, scripts can run post-clone, pre-build & post-build.

https://docs.microsoft.com/en-us/appcenter/build/custom/scripts/

I'll contact them!

for syncing btwn the two repositories, do you think something like https://github.com/livechat/copycat is a good idea? (first result from googling)

RubenSandwich commented 5 years ago

Hmm,

I'd actually lean more towards just using a pre-build script to move the required file over. (Those scripts should be easy to write and I'll write once everything is set up correctly. Is the normal build working for you yet?) I think that would be easier than trying to keep two repos in sync.

Do you know if when we run the build script does it have access to the assets repo?

Ruben

On Fri, Sep 20, 2019 at 12:43 PM Aron Ambrosiani notifications@github.com wrote:

@RubenSandwich https://github.com/RubenSandwich yes, scripts can run post-clone, pre-build & post-build.

https://docs.microsoft.com/en-us/appcenter/build/custom/scripts/

I'll contact them!

for syncing btwn the two repositories, do you think something like https://github.com/livechat/copycat is a good idea? (first result from googling)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NordicMuseum/Nordic-Museum-Audio-Guide/issues/19?email_source=notifications&email_token=AAO53Q7N3XTAUAQHLUPTOL3QKT4SLA5CNFSM4HGKJ5PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7HIHQY#issuecomment-533627843, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO53Q25Z3U2UWUDOHDSERTQKT4SLANCNFSM4HGKJ5PA .

Ambrosiani commented 5 years ago

trying a post-clone script now that clones the private assets into the correct folder. Might even work :)

Ambrosiani commented 5 years ago

@RubenSandwich builds fine, but it seems I need to add an ad-hoc provisioning profile rather than the distribution profile. Will try that tomorrow!

https://docs.microsoft.com/en-us/appcenter/distribution/auto-provisioning

Ambrosiani commented 5 years ago

@RubenSandwich as far as I can tell it works for iOS now. Build gets submitted to Testflight & we should be able to publish from there. I'll set Appcenter to increment the build number automatically as well. I bumped the version to 2.0. Will take a look at android now.

RubenSandwich commented 5 years ago

@Ambrosiani,

Few updates for your post-clone script:

(The first two are the secrets for our App Center Analytics. You can test if it works by launching the App and seeing if the "Active Devices" in the App Center Analytics goes up.)

Also are you sure that your the testflight builds works?

Ambrosiani commented 5 years ago

@RubenSandwich I put npm run transfer-assets-android in a second "pre-build" script which – if I understand everything correctly – runs after npm i (while post-clone runs before dependencies are installed). Testing now!

RubenSandwich commented 5 years ago

Okay just as long as the final assets are already loaded. Android needs the audio files to be in a very exact location and name format which is what that script that I wrote does. Let me know if it works and if not how it’s breaking.

On Mon, Sep 23, 2019 at 1:50 PM Aron Ambrosiani notifications@github.com wrote:

@RubenSandwich https://github.com/RubenSandwich I put npm run transfer-assets-android in a second "pre-build" script which – if I understand everything correctly – runs after npm i (while post-clone runs before dependencies are installed). Testing now!

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/NordicMuseum/Nordic-Museum-Audio-Guide/issues/19?email_source=notifications&email_token=AAO53Q4GCK7DLANYHSA4FGDQLD6URA5CNFSM4HGKJ5PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7LWKMY#issuecomment-534209843, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO53QZNEAJXYMI5C4GORYDQLD6URANCNFSM4HGKJ5PA .

Ambrosiani commented 5 years ago

@RubenSandwich hm, the first build made it to the App Store but not the later ones. When running the same scripts locally & then building, asset loading & appcenter analytics work as expected.

RubenSandwich commented 5 years ago

@Ambrosiani Strange. What error is it giving you? I also logged into App Center, went to build 8 and manually told it to push that build to TestFlight. When I did that I got the error:

Oh no! Build 8 failed to distribute. Error: Bad Gateway: undefined

It looks like they are having troubles: https://status.appcenter.ms. But that status webpage still says that their "distribute" service is working fine.

Do you mind reaching out to them and asking about it?

Ambrosiani commented 5 years ago

@RubenSandwich seems like Appcenter prefers manual signing. I'll try the steps outlined here:

https://intercom.help/appcenter/en/articles/1617765-ios-signing-issues-explained

edit: also, the bundle identifier wasn't the same as the app store app – hopefully that's the only reason it didn't work.

RubenSandwich commented 5 years ago

@Ambrosiani Hmm. Okay. We can return this time, just as long as you can build and submit to the store.

How is setting up the Android CD going?

Ambrosiani commented 5 years ago

have switched from automatic to manual signing for iOS now, uploading a local build to the app store now before testing in Appcenter again.

Also doing my first run at an android release build. Need to upload it the Play Console before I can add the appcenter integration.