search

NordicMuseum / Nordic-Museum-Audio-Guide

An inclusive audio guide for The Nordic Museum
https://nordicmuseum.github.io/Nordic-Museum-Audio-Guide/
MIT License
14 stars 6 forks source link

4digits #22

Closed Ambrosiani closed 4 years ago

Ambrosiani commented 5 years ago

@RubenSandwich this was my first take on 4 digits – #14

RubenSandwich commented 5 years ago

@Ambrosiani Sorry I totally missed this. I think it's good the only change I would make is to move the numberOfDigits variable out of Settings and into a JSON file with the Google tracking ID. The reason why is I fear if this variable is buried in code, non-programmers will miss it or feel uneasy about changing it.

Ambrosiani commented 5 years ago

Agree 100 %! (And you didn’t miss it, I hadn’t pushed my local changes)

Ambrosiani commented 4 years ago

solved in v2