NordicMuseum / Nordic-Museum-Audio-Guide

An inclusive audio guide for The Nordic Museum
https://nordicmuseum.github.io/Nordic-Museum-Audio-Guide/
MIT License
14 stars 6 forks source link

Audio (Native Module - Library Track) #30

Closed sticknor closed 5 years ago

Ambrosiani commented 5 years ago

@sticknor @RubenSandwich there's a change in the mp3 file names I'd like to implement at the same time. right now the files are named id/language.mp3 which means that there are 200 different sv.mp3 and en.mp3. Can we change this to id/id-language.mp3 instead, i.e. repeating the id in the filename? so instead of 201/sv.mp3 it would be 201/201-sv.mp3. I can batch rename the files. will make it easier to find stuff :)

RubenSandwich commented 5 years ago

Yeah that shouldn’t cause too many problems. Let’s do it.

On Fri, Sep 13, 2019 at 4:34 AM Aron Ambrosiani notifications@github.com wrote:

@sticknor https://github.com/sticknor @RubenSandwich https://github.com/RubenSandwich there's a change in the mp3 file names I'd like to implement at the same time. right now the files are named id/language.mp3 which means that there are 200 different sv.mp3 and en.mp3. Can we change this to id/id-language.mp3 instead, i.e. repeating the id in the filename? so instead of 201/sv.mp3 it would be 201/201-sv.mp3. I can batch rename the files. will make it easier to find stuff :)

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/NordicMuseum/Nordic-Museum-Audio-Guide/issues/30?email_source=notifications&email_token=AAO53Q362TPSW4CJAS745B3QJNF7ZA5CNFSM4IOMFX42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6ULP7Q#issuecomment-531150846, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO53Q2TFJAAWMQAYUSTUDTQJNF7ZANCNFSM4IOMFX4Q .

Ambrosiani commented 5 years ago

@RubenSandwich @sticknor awesome, I'll figure out a good batch renaming here locally & can push new placeholder mp3's after that. It was easier without the dash so they are 201/201en.mp3 etc.

Ambrosiani commented 5 years ago

accidentally included the .pbxproj and package-lock files but here are the renamed audio files… https://github.com/NordicMuseum/Nordic-Museum-Audio-Guide/commit/6df35098ea0fedfc85cebf77b8a57a7921f9b825