v2 remaining work breakdown

RubenSandwich commented 5 years ago

@sticknor

[x] Style tutorial
[x] New Device reducer which combines the reducers:
- [x] tutorial
- [x] localization
[x] search by number keypad is partly hidden by the bottomPlayer
[x] Search bug : first time you use it, plays two tracks (was related to some commented code)
[x] NearMe displays highlights twice (this was a problem in the previous version as well for a while) – I think it is showing the highlight tracks both from the highlight tour and the Swedish Folk Art tour. I.e. how do we remove all highlights but the ones in the Highlight tour from the NearMe screen?
[x] Search by number working:
- [x] Move number logic into reducer
- [x] Allow settings number of digits needed (https://github.com/NordicMuseum/Nordic-Museum-Audio-Guide/issues/14)
[x] Styling nearMe (fake the data for now.)
[x] Near Me Button Presses working
[x] Remove unused code/assets/strings:
- [x] old localization - actions/reducer/code
- [x] old nav - actions/reducer/code
[x] Android style fixes
- [x] Parallax top bar
[x] Add google export script to repo
[x] Tourstop headings are centered on the image, should be at bottom
[x] Update dynamic image locations
[x] Reset to tutorial on charging
[x] when museum mode is enabled, the app quits (crashes?) when a charger is unplugged. The tutorial part works as expected.

@RubenSandwich

[x] Localization: Missing translations are not filled in with a default language.
[x] RTL bugs
[x] in Arabic, some RTL changes still remain: number pad (<-- I thought #s stayed LTR? -sam), play all button, bottom navigation, tourstop titles in tours.jsx
[ ] Screenreader bugs
[x] Beacon support
[ ] Uncomment and test accessibility
[ ] Splashscreen
[ ] Analytics
[ ] Next playing counter
[ ] Tap title to go to active tour stop (v2.1)
[x] Welcome image & tourstop images are not displayed
[x] NearMe screen doesn't display the floor number
[ ] apk extension or something else? (v2.1)

@Ambrosiani

[x] iOS CD
[ ] Writing new README
[x] Device testing and bug reporting
[x] Prove splashscreen icon to Ruben
[ ] No floor 1 beacon block rules?
[x]  Compressing mp3s? Maybe move to aac? (80-100mb max.)
[ ] Android CD (v2.1)
[ ]  Move to 96k aac (v2.1)

To sort

[x] previous audio doesn't stop when selecting another track

Build Deadlines:

[x] Running Build - September 26th 8 am CEST (2 am EST) Major features should work, but the main purpose of this build is to submit to App Stores to find any places where we are out of App Store compliance.
[x] Beta Build - September 30th 8 am CEST (2 am EST) All features working, used for staff training and bug testing.
[ ] Final Build - October 3rd 8 am CEST (2 am EST) Bug fixes and polish.

Ambrosiani commented 5 years ago

we're getting closer!

[x] 🎉 beacons are fully functioning! 🎉
[x] 🎉 amenities are fully functioning! 🎉
[x] I've added ITSAppUsesNonExemptEncryption=NO to XCode to get rid of the warning in TestFlight
[x] I've removed the build number from appVersion

relevant screenshots

IMG_7FB6479F2CE7-1

RubenSandwich commented 5 years ago

Aron can you add those bugs as a checklist on this issue?

On Tue, Oct 1, 2019 at 5:12 AM Aron Ambrosiani notifications@github.com wrote:

we're getting closer!

feedback from build 14, ios (doing android shortly):

welcome image & tourstop images are not displayed

tourstop headings are centered on the image, should be at bottom

when museum mode is enabled, the app quits (crashes?) when a charger is unplugged. The tutorial part works as expected.

in Arabic, some RTL changes still remain: number pad, play all button, bottom navigation, tourstop titles in tours.jsx

🎉 beacons are fully functioning! 🎉

NearMe screen doesn't display the floor number

NearMe displays highlights twice (this was a problem in the previous version as well for a while) – I think it is showing the highlight tracks both from the highlight tour and the Swedish Folk Art tour. I.e. how do we remove all highlights but the ones in the Highlight tour from the NearMe screen?

search by number keypad is partly hidden by the bottomPlayer

🎉 amenities are fully functioning! 🎉

already fixed

I've added ITSAppUsesNonExemptEncryption=NO to XCode to get rid of the warning in TestFlight

I've removed the build number from appVersion

relevant screenshots

[image: IMG_7FB6479F2CE7-1] https://user-images.githubusercontent.com/2394405/65946334-37f9de80-e436-11e9-991d-d54b464d26cc.jpeg [image: IMG_4293] https://user-images.githubusercontent.com/2394405/65947761-3ed62080-e439-11e9-8e69-028d1a304244.PNG [image: IMG_4292] https://user-images.githubusercontent.com/2394405/65947763-3ed62080-e439-11e9-9e0e-d1e7790c690f.PNG [image: IMG_4291] https://user-images.githubusercontent.com/2394405/65947765-3ed62080-e439-11e9-8367-54ece7474be3.PNG [image: IMG_4296] https://user-images.githubusercontent.com/2394405/65948874-5d3d1b80-e43b-11e9-971c-dfcf4a9a5c80.PNG [image: IMG_4295] https://user-images.githubusercontent.com/2394405/65948875-5d3d1b80-e43b-11e9-8bae-f772a79e3326.PNG [image: IMG_4297] https://user-images.githubusercontent.com/2394405/65949322-43e89f00-e43c-11e9-8435-77fdac7e1144.PNG

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/NordicMuseum/Nordic-Museum-Audio-Guide/issues/34?email_source=notifications&email_token=AAO53Q4U5OXAS3VZTCWGT5DQMMH6BA5CNFSM4I2AED72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAASHII#issuecomment-536945569, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO53QYOSHGXM7NYRAVSIVLQMMH6BANCNFSM4I2AED7Q .

RubenSandwich commented 5 years ago

@Ambrosiani I had some time and looked a bit into:

 Compressing mp3s? Maybe move to aac? (80-100mb max.)

Even with medium quality aac I was only able to get the audio down to 730mb from 1gb. So I don't think the compression we need is even possible...

Ambrosiani commented 5 years ago

@RubenSandwich yeah, I did some experiments as well. Might be a good idea to switch anyway to bring down the app size, I'll find a good enough bitrate.

RubenSandwich commented 5 years ago

Yeah, try it. You can listen for the same event in each container.

One problem that might arise is how will we change the text of the bottomBar during locale changes? Should we just reset the app for any locale changes to avoid mergeOptions? (That might be easier.)

On Fri, Oct 4, 2019 at 3:20 PM Sam notifications@github.com wrote:

@RubenSandwich https://github.com/RubenSandwich , I see one solution forward and with preliminary testing, it will work. If we can avoid merging options on locale change, we can avoid turning the bottom bar white.

We can set the translated title in each container file instead of registerScreens. Should I proceed with this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NordicMuseum/Nordic-Museum-Audio-Guide/issues/34?email_source=notifications&email_token=AAO53Q4M42HL22ZH6UKQYT3QM6JPFA5CNFSM4I2AED72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAMUUMY#issuecomment-538528307, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO53Q7STLH66TLU73S63MTQM6JPFANCNFSM4I2AED7Q .

sticknor commented 5 years ago

@RubenSandwich Actually just removed that in hopes you hadn't see / worried about it yet... I was able to get it to work by specifying the bottomTabs background color on the screen type merge options. Redundant, and there's a small flicker, but seems like the best case scenario.

You're right, not merging options will make the tab bar translation too difficult.

RubenSandwich commented 5 years ago

Haha no worries thanks for always being two steps ahead Sam. 💪🏽

On Fri, Oct 4, 2019 at 3:32 PM Sam notifications@github.com wrote:

@RubenSandwich https://github.com/RubenSandwich Actually just removed that in hopes you hadn't see / worried about it yet... I was able to get it to work by specifying the bottomTabs background color on the screen type merge options. Redundant, and there's a small flicker, but seems like the best case scenario.

You're right, not merging options will make the tab bar translation too difficult.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NordicMuseum/Nordic-Museum-Audio-Guide/issues/34?email_source=notifications&email_token=AAO53Q6YH3BXKHIAHYAWXO3QM6K4LA5CNFSM4I2AED72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAMVRQY#issuecomment-538532035, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO53Q2QX4YIL57RMY3OIMLQM6K4LANCNFSM4I2AED7Q .

Ambrosiani commented 5 years ago

@RubenSandwich @sticknor Sam is correct, the numpad should not change direction in RTL.

RubenSandwich commented 5 years ago

K, I think I just fixed most of the RTL bugs.

On Sun, Oct 6, 2019 at 3:10 PM Aron Ambrosiani notifications@github.com wrote:

@RubenSandwich https://github.com/RubenSandwich @sticknor https://github.com/sticknor Sam is correct, the numpad should not change direction in RTL.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NordicMuseum/Nordic-Museum-Audio-Guide/issues/34?email_source=notifications&email_token=AAO53QY5WUQ52VOZ7QM7WNTQNIZZJA5CNFSM4I2AED72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAORTDA#issuecomment-538777996, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO53Q6TCTS3GWGF73JXF33QNIZZJANCNFSM4I2AED7Q .

Ambrosiani commented 5 years ago

@RubenSandwich @sticknor I added an additional bug: previous audio doesn't stop when selecting another track

also my development build is running fine but the release build is crashing when a language is selected in the tutorial. I guess the release scheme needs some changes?

RubenSandwich commented 5 years ago

Okay, thanks Aron.

I will fix those tonight. I will also email you an update shortly.

Ruben

On Mon, Oct 7, 2019 at 10:17 AM Aron Ambrosiani notifications@github.com wrote:

@RubenSandwich https://github.com/RubenSandwich @sticknor https://github.com/sticknor I added an additional bug: previous audio doesn't stop when selecting another track

also my development build is running fine but the release build is crashing when a language is selected in the tutorial. I guess the release scheme needs some changes?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NordicMuseum/Nordic-Museum-Audio-Guide/issues/34?email_source=notifications&email_token=AAO53Q37NOAMUA54XGQQMJTQNNAG3A5CNFSM4I2AED72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAQQBHQ#issuecomment-539033758, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO53QYGQLG4YZTCMQWYZC3QNNAG3ANCNFSM4I2AED7Q .

RubenSandwich commented 5 years ago

@Ambrosiani I believe I have now fixed those bugs. Talk to you tomorrow.

Ambrosiani commented 5 years ago

@RubenSandwich awesome! the testflight build works as expected now.

NordicMuseum / Nordic-Museum-Audio-Guide