As character mode by-passes a lot of the functionality of NrfTerminalCommander, it might be reasonable to move the commands and unspecifiedCommandHandler options and maybe others to be part of the 'line' mode in the same way that onData and onKey are part of the 'character' mode.
Not necessary but it seems like it might introduce more symmetry in the API. I just wanted to record the thought while it was on my mind. Feel free to close if we don't act on it.
We've just merged https://github.com/NordicPlayground/pc-xterm-lib/pull/20 which was done without any breaking changes but it introduces
onDataandonKeyhandlers for a new 'character' mode.As character mode by-passes a lot of the functionality of
NrfTerminalCommander, it might be reasonable to move thecommandsandunspecifiedCommandHandleroptions and maybe others to be part of the 'line' mode in the same way thatonDataandonKeyare part of the 'character' mode.Not necessary but it seems like it might introduce more symmetry in the API. I just wanted to record the thought while it was on my mind. Feel free to close if we don't act on it.