We add 'connect' and 'disconnect' methods to all addons and move the 'onData' and 'onKey' handlers into those methods so that we can connect and disconnect them at will.
We do this so that character mode is free of any kind of artificial history or key capture. Without this the setup gets confused between the history in the HistoryAddon and the history in the shell itself.
Checklist
[ ] This adds required methods to the NrfCommanderAddon base class. This might impact other users of this library. Should we provide default implementations of them so that it doesn't break anyone's code?
And reconnect them in line mode.
We add 'connect' and 'disconnect' methods to all addons and move the 'onData' and 'onKey' handlers into those methods so that we can connect and disconnect them at will.
We do this so that character mode is free of any kind of artificial history or key capture. Without this the setup gets confused between the history in the HistoryAddon and the history in the shell itself.
Checklist
NrfCommanderAddon
base class. This might impact other users of this library. Should we provide default implementations of them so that it doesn't break anyone's code?