search

NordicSemiconductor / Android-BLE-Library

A library that makes working with Bluetooth LE on Android a pleasure. Seriously.
BSD 3-Clause "New" or "Revised" License
2.04k stars 419 forks source link

no.nordicsemi.android.ble.exception.RequestFailedException #437

Closed daidaijie closed 1 year ago

daidaijie commented 1 year ago

We have an exception in the library using version 2.6.0-alpha03(also on 2.5.1). Is there any way to fix or catch this exception to prevent the app from crashing?

daidaijie commented 1 year ago 
no.nordicsemi.android.ble.exception.RequestFailedException Request failed with status 133
no.nordicsemi.android.ble.ktx.RequestSuspendKt$suspendNonCancellable$2$2.onRequestFailed(RequestSuspend.kt:379)
no.nordicsemi.android.ble.Request.lambda$notifyFail$2$no-nordicsemi-android-ble-Request(Request.java:1266)
no.nordicsemi.android.ble.Request$$ExternalSyntheticLambda3.run(Unknown Source:6)
no.nordicsemi.android.ble.Request$1.post(Request.java:172)
no.nordicsemi.android.ble.Request.notifyFail(Request.java:1263)
no.nordicsemi.android.ble.BleManagerHandler$3.onDescriptorWrite(BleManagerHandler.java:2503)
android.bluetooth.BluetoothGatt$1$11.run(BluetoothGatt.java:650)
android.os.Handler.handleCallback(Handler.java:938)
android.os.Handler.dispatchMessage(Handler.java:99)
android.os.Looper.loopOnce(Looper.java:226)
android.os.Looper.loop(Looper.java:313)
android.app.ActivityThread.main(ActivityThread.java:8663)
java.lang.reflect.Method.invoke(Native Method)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:567)
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1135)
daidaijie commented 1 year ago

Device is Samsung note10+, Android 12

philips77 commented 1 year ago

If you're using suspend() method you may either wrap it in try-catch or add a global exception handler for the launch { ... } block.

philips77 commented 1 year ago

As you can see here: https://github.com/NordicSemiconductor/Android-BLE-Library/blob/8653cfae7d94799a926acc2f4fd1220da1abfeb7/ble-ktx/src/main/java/no/nordicsemi/android/ble/ktx/RequestSuspend.kt#L22-L28 this method may throw some exceptions.

If that's a ConnectRequest, you may also use .retry(x, delay) method, so it will retry number of times: https://github.com/NordicSemiconductor/Android-BLE-Library/blob/8653cfae7d94799a926acc2f4fd1220da1abfeb7/ble/src/main/java/no/nordicsemi/android/ble/ConnectRequest.java#L169-L174

daidaijie commented 1 year ago

Sorry, I found that I forgot to catch the exception somewhere in my code, thank you for your reply