Bug fix: Write correct descriptor value when attempting to disable notifications

NordicSemiconductor / Android-BLE-Library

A library that makes working with Bluetooth LE on Android a pleasure. Seriously.

BSD 3-Clause "New" or "Revised" License

1.98k stars 413 forks source link

Bug fix: Write correct descriptor value when attempting to disable notifications #543

Closed muscardinus closed 6 months ago

muscardinus commented 6 months ago

Disabling a characteristic notification does not work correctly. It's disabled locally (gatt.setCharacteristicNotification(characteristic, false)) but the descriptor value written to the BLE device is not correct (ENABLE_NOTIFICATION_VALUE instead of DISABLE_NOTIFICATION_VALUE).

This is a fix.

CLAassistant commented 6 months ago

All committers have signed the CLA.

philips77 commented 6 months ago

Wow, that's a good finding. It was like this for years!

muscardinus commented 6 months ago

Thanks 🙂