search

NordicSemiconductor / Android-DFU-Library

Device Firmware Update library and Android app
http://www.nordicsemi.com/dfu
BSD 3-Clause "New" or "Revised" License
753 stars 263 forks source link

Use positional format specifier for uploading resource #435

Closed Silverdark closed 2 months ago

Silverdark commented 5 months ago

This PR fixes the following issue:

values.xml(2): Error APT2000 : multiple substitutions specified in non-positional format; did you mean to add the formatted="false" attribute?.
values.xml: Error APT2261 : file failed to compile.

Fixes #428

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

Silverdark commented 5 months ago

Hi @philips77,

Have you had time to check if you can integrate the change, or is there anything I can do to assist?

philips77 commented 4 months ago

Hi, I'm busy with other projects currently, but I'll try to have a look at DFU next week.

Silverdark commented 3 months ago

Hi @philips77, just a friendly reminder. Would appreciate if you have time to check it.

ksidirop-laerdal commented 2 months ago

I need this one to be merged as well. It's an annoying blocker.

philips77 commented 2 months ago

Ok, will do it today. Sorry, I forgot.

philips77 commented 2 months ago

Released in 2.5. Could you check if everything is OK now?