search

NordicSemiconductor / Android-nRF-Mesh-Library

The Bluetooth Mesh Provisioner and Configurator library.
https://www.nordicsemi.com/
BSD 3-Clause "New" or "Revised" License
414 stars 177 forks source link

GenericBatteryGet and GenericBatteryStatus implementation #533

Closed JulesDommartin closed 2 years ago

JulesDommartin commented 2 years ago

Hello, since I asked for this feature, I tried to implement it myself following the same code architecture and syntax as the other mesh Generic messages.

I hope it will be merged soon, and that it will help the project !

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

roshanrajaratnam commented 2 years ago

@JulesDommartin thank you for your contribution and it will definitely help our project! By the way please make sure to sign the CLA so that I can merge your changes straight away,

JulesDommartin commented 2 years ago

I don't understand why the CLA shows that I didn't accept them. It seems like it did work

image

What should I do more ? Did I missed something ?

JulesDommartin commented 2 years ago

I don't understand why the CLA shows that I didn't accept them. It seems like it did work image

What should I do more ? Did I missed something ?

Nevermind, I got it, my account wasn't configured properly. Now it is fine ! 😄