search

NordicSemiconductor / Android-nRF-Mesh-Library

The Bluetooth Mesh Provisioner and Configurator library.
https://www.nordicsemi.com/
BSD 3-Clause "New" or "Revised" License
408 stars 178 forks source link

taiSeconds should probably be long #564

Open DomiR opened 1 year ago

DomiR commented 1 year ago

taiSeconds are 40bits => 5 bytes which means it won't fit into 4 byte int

https://github.com/NordicSemiconductor/Android-nRF-Mesh-Library/blob/1e71dabe7cd0a1047db4b662d2af41fb5e9e3584/mesh/src/main/java/no/nordicsemi/android/mesh/transport/TimeStatus.java#L33

which means the BitReader should also parse to long

roshanrajaratnam commented 1 year ago

@DomiR sorry for the delayed reply. Thanks for spotting this. I'll try to find some time to fix this. If you have done already, please do send us a PR :)